Re: [PATCH v9 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-10 Thread Steen Hegelund
On 10.12.2020 15:16, Andrew Lunn wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > So why are returning link up information? Yes that was a bit of a hijacking of the function. I will remove that. I also removed the dependency on this behaviou

Re: [PATCH v9 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-10 Thread Steen Hegelund
On 10.12.2020 03:11, Andrew Lunn wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 01b53f86004c..f6a094c81e86 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -66,9 +66,11

Re: [PATCH v9 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-10 Thread Andrew Lunn
> > So why are returning link up information? > > Yes that was a bit of a hijacking of the function. I will remove that. > I also removed the dependency on this behaviour in the client driver in the > meantime. > > I think a status function on the generic phy would be useful, but I will > take t

Re: [PATCH v9 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-09 Thread Andrew Lunn
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 01b53f86004c..f6a094c81e86 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -66,9 +66,11 @@ source "drivers/phy/broadcom/Kconfig" > source "drivers/phy/cadence/Kconfig" > source "drivers/phy/freescale/Kconfig" >