Re: [PATCH v8 bpf-next 09/13] bpf: Add d_path helper

2020-07-30 Thread Jiri Olsa
On Wed, Jul 29, 2020 at 09:11:17PM +0100, Al Viro wrote: > On Wed, Jul 22, 2020 at 11:12:19PM +0200, Jiri Olsa wrote: > > > +BPF_CALL_3(bpf_d_path, struct path *, path, char *, buf, u32, sz) > > +{ > > + char *p = d_path(path, buf, sz - 1); > > + int len; > > + > > + if (IS_ERR(p)) { > > +

Re: [PATCH v8 bpf-next 09/13] bpf: Add d_path helper

2020-07-30 Thread Jiri Olsa
On Wed, Jul 29, 2020 at 09:17:40PM +0100, Al Viro wrote: > On Wed, Jul 22, 2020 at 11:12:19PM +0200, Jiri Olsa wrote: > > > +BTF_SET_START(btf_whitelist_d_path) > > +BTF_ID(func, vfs_truncate) > > +BTF_ID(func, vfs_fallocate) > > +BTF_ID(func, dentry_open) > > +BTF_ID(func, vfs_getattr) > > +BTF_I

Re: [PATCH v8 bpf-next 09/13] bpf: Add d_path helper

2020-07-29 Thread Al Viro
On Wed, Jul 22, 2020 at 11:12:19PM +0200, Jiri Olsa wrote: > +BTF_SET_START(btf_whitelist_d_path) > +BTF_ID(func, vfs_truncate) > +BTF_ID(func, vfs_fallocate) > +BTF_ID(func, dentry_open) > +BTF_ID(func, vfs_getattr) > +BTF_ID(func, filp_close) > +BTF_SET_END(btf_whitelist_d_path) While we are at

Re: [PATCH v8 bpf-next 09/13] bpf: Add d_path helper

2020-07-29 Thread Al Viro
On Wed, Jul 22, 2020 at 11:12:19PM +0200, Jiri Olsa wrote: > +BPF_CALL_3(bpf_d_path, struct path *, path, char *, buf, u32, sz) > +{ > + char *p = d_path(path, buf, sz - 1); > + int len; > + > + if (IS_ERR(p)) { > + len = PTR_ERR(p); > + } else { > + len = s

Re: [PATCH v8 bpf-next 09/13] bpf: Add d_path helper

2020-07-29 Thread Jiri Olsa
On Tue, Jul 28, 2020 at 12:47:03PM -0700, Andrii Nakryiko wrote: > On Wed, Jul 22, 2020 at 2:14 PM Jiri Olsa wrote: > > > > Adding d_path helper function that returns full path for > > given 'struct path' object, which needs to be the kernel > > BTF 'path' object. The path is returned in buffer pr

Re: [PATCH v8 bpf-next 09/13] bpf: Add d_path helper

2020-07-28 Thread Andrii Nakryiko
On Wed, Jul 22, 2020 at 2:14 PM Jiri Olsa wrote: > > Adding d_path helper function that returns full path for > given 'struct path' object, which needs to be the kernel > BTF 'path' object. The path is returned in buffer provided > 'buf' of size 'sz' and is zero terminated. > > bpf_d_path(&file-

[PATCH v8 bpf-next 09/13] bpf: Add d_path helper

2020-07-22 Thread Jiri Olsa
Adding d_path helper function that returns full path for given 'struct path' object, which needs to be the kernel BTF 'path' object. The path is returned in buffer provided 'buf' of size 'sz' and is zero terminated. bpf_d_path(&file->f_path, buf, size); The helper calls directly d_path function