Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-20 Thread Magnus Karlsson
On Mon, Apr 19, 2021 at 8:56 AM Lorenzo Bianconi wrote: > > > On Sun, Apr 18, 2021 at 6:18 PM Jesper Dangaard Brouer > > wrote: > > > > > > On Fri, 16 Apr 2021 16:27:18 +0200 > > > Magnus Karlsson wrote: > > > > > > > On Thu, Apr 8, 2021 at 2:51 PM Lorenzo Bianconi > > > > wrote: > > > > > > >

Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-18 Thread Lorenzo Bianconi
> On Sun, Apr 18, 2021 at 6:18 PM Jesper Dangaard Brouer > wrote: > > > > On Fri, 16 Apr 2021 16:27:18 +0200 > > Magnus Karlsson wrote: > > > > > On Thu, Apr 8, 2021 at 2:51 PM Lorenzo Bianconi > > > wrote: > > > > > > > > This series introduce XDP multi-buffer support. The mvneta driver is > >

Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-18 Thread Magnus Karlsson
On Sun, Apr 18, 2021 at 6:18 PM Jesper Dangaard Brouer wrote: > > On Fri, 16 Apr 2021 16:27:18 +0200 > Magnus Karlsson wrote: > > > On Thu, Apr 8, 2021 at 2:51 PM Lorenzo Bianconi wrote: > > > > > > This series introduce XDP multi-buffer support. The mvneta driver is > > > the first to support t

Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-18 Thread Jesper Dangaard Brouer
On Fri, 16 Apr 2021 16:27:18 +0200 Magnus Karlsson wrote: > On Thu, Apr 8, 2021 at 2:51 PM Lorenzo Bianconi wrote: > > > > This series introduce XDP multi-buffer support. The mvneta driver is > > the first to support these new "non-linear" xdp_{buff,frame}. Reviewers > > please focus on how thes

Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-16 Thread Daniel Borkmann
On 4/16/21 11:29 PM, Lorenzo Bianconi wrote: Took your patches for a test run with the AF_XDP sample xdpsock on an i40e card and the throughput degradation is between 2 to 6% depending on the setup and microbenchmark within xdpsock that is executed. And this is without sending any multi frame pa

Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-16 Thread Lorenzo Bianconi
> > Took your patches for a test run with the AF_XDP sample xdpsock on an > i40e card and the throughput degradation is between 2 to 6% depending > on the setup and microbenchmark within xdpsock that is executed. And > this is without sending any multi frame packets. Just single frame > ones. Tirt

Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-16 Thread Magnus Karlsson
On Thu, Apr 8, 2021 at 2:51 PM Lorenzo Bianconi wrote: > > This series introduce XDP multi-buffer support. The mvneta driver is > the first to support these new "non-linear" xdp_{buff,frame}. Reviewers > please focus on how these new types of xdp_{buff,frame} packets > traverse the different layer

Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-13 Thread Eelco Chaudron
On 9 Apr 2021, at 2:56, John Fastabend wrote: Lorenzo Bianconi wrote: This series introduce XDP multi-buffer support. The mvneta driver is the first to support these new "non-linear" xdp_{buff,frame}. Reviewers please focus on how these new types of xdp_{buff,frame} packets traverse the di

Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-09 Thread Lorenzo Bianconi
> Lorenzo Bianconi wrote: [...] > > I just read the commit messages for v8 so far. But, I'm still wondering how > to handle use cases where we want to put extra bytes at the end of the > packet, or really anywhere in the general case. We can extend tail with above > is there anyway to then write

RE: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-08 Thread John Fastabend
Lorenzo Bianconi wrote: > This series introduce XDP multi-buffer support. The mvneta driver is > the first to support these new "non-linear" xdp_{buff,frame}. Reviewers > please focus on how these new types of xdp_{buff,frame} packets > traverse the different layers and the layout design. It is on

[PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-08 Thread Lorenzo Bianconi
This series introduce XDP multi-buffer support. The mvneta driver is the first to support these new "non-linear" xdp_{buff,frame}. Reviewers please focus on how these new types of xdp_{buff,frame} packets traverse the different layers and the layout design. It is on purpose that BPF-helpers are kep