Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-02 Thread Lukasz Stelmach
It was <2020-12-02 śro 09:18>, when Jakub Kicinski wrote: > On Wed, 02 Dec 2020 11:46:28 +0100 Lukasz Stelmach wrote: >> >> + status = netif_rx(skb); >> > >> > If I'm reading things right this is in process context, so netif_rx_ni() >> > >> >> Is it? The stack looks as follows >> >> ax887

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-02 Thread Jakub Kicinski
On Wed, 02 Dec 2020 11:46:28 +0100 Lukasz Stelmach wrote: > >> + status = netif_rx(skb); > > > > If I'm reading things right this is in process context, so netif_rx_ni() > > > > Is it? The stack looks as follows > > ax88796c_skb_return() > ax88796c_rx_fixup() > ax88796c_receive()

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-02 Thread Lukasz Stelmach
It was <2020-11-25 śro 13:26>, when Jakub Kicinski wrote: > On Tue, 24 Nov 2020 13:03:30 +0100 Łukasz Stelmach wrote: >> +static int >> +ax88796c_start_xmit(struct sk_buff *skb, struct net_device *ndev) >> +{ >> +struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> + >> +skb_queu

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-25 Thread Jakub Kicinski
On Tue, 24 Nov 2020 13:03:30 +0100 Łukasz Stelmach wrote: > ASIX AX88796[1] is a versatile ethernet adapter chip, that can be > connected to a CPU with a 8/16-bit bus or with an SPI. This driver > supports SPI connection. > > The driver has been ported from the vendor kernel for ARTIK5[2] > boards

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-25 Thread Jakub Kicinski
On Tue, 24 Nov 2020 13:03:30 +0100 Łukasz Stelmach wrote: > +static int > +ax88796c_start_xmit(struct sk_buff *skb, struct net_device *ndev) > +{ > + struct ax88796c_device *ax_local = to_ax88796c_device(ndev); > + > + skb_queue_tail(&ax_local->tx_wait_q, skb); > + if (skb_queue_len(&ax

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-24 Thread Andrew Lunn
On Tue, Nov 24, 2020 at 01:03:30PM +0100, Łukasz Stelmach wrote: > ASIX AX88796[1] is a versatile ethernet adapter chip, that can be > connected to a CPU with a 8/16-bit bus or with an SPI. This driver > supports SPI connection. > > The driver has been ported from the vendor kernel for ARTIK5[2] >

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-24 Thread Lukasz Stelmach
It was <2020-11-24 wto 13:17>, when Krzysztof Kozlowski wrote: > On Tue, Nov 24, 2020 at 01:03:30PM +0100, Łukasz Stelmach wrote: >> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be >> connected to a CPU with a 8/16-bit bus or with an SPI. This driver >> supports SPI connection. >>

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-24 Thread Krzysztof Kozlowski
On Tue, Nov 24, 2020 at 01:03:30PM +0100, Łukasz Stelmach wrote: > ASIX AX88796[1] is a versatile ethernet adapter chip, that can be > connected to a CPU with a 8/16-bit bus or with an SPI. This driver > supports SPI connection. > > The driver has been ported from the vendor kernel for ARTIK5[2] >

[PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-24 Thread Łukasz Stelmach
ASIX AX88796[1] is a versatile ethernet adapter chip, that can be connected to a CPU with a 8/16-bit bus or with an SPI. This driver supports SPI connection. The driver has been ported from the vendor kernel for ARTIK5[2] boards. Several changes were made to adapt it to the current kernel which in