Re: [PATCH v7 07/11] thermal: Use mode helpers in drivers

2020-06-29 Thread Bartlomiej Zolnierkiewicz
On 6/29/20 2:29 PM, Andrzej Pietrasiewicz wrote: > Use thermal_zone_device_{en|dis}able() and thermal_zone_device_is_enabled(). > > Consequently, all set_mode() implementations in drivers: > > - can stop modifying tzd's "mode" member, > - shall stop taking tzd's lock, as it is taken in the help

[PATCH v7 07/11] thermal: Use mode helpers in drivers

2020-06-29 Thread Andrzej Pietrasiewicz
Use thermal_zone_device_{en|dis}able() and thermal_zone_device_is_enabled(). Consequently, all set_mode() implementations in drivers: - can stop modifying tzd's "mode" member, - shall stop taking tzd's lock, as it is taken in the helpers - shall stop calling thermal_zone_device_update() as it is

Re: [PATCH v7 07/11] thermal: Use mode helpers in drivers

2020-06-29 Thread Amit Kucheria
On Mon, Jun 29, 2020 at 5:59 PM Andrzej Pietrasiewicz wrote: > > Use thermal_zone_device_{en|dis}able() and thermal_zone_device_is_enabled(). > > Consequently, all set_mode() implementations in drivers: > > - can stop modifying tzd's "mode" member, > - shall stop taking tzd's lock, as it is taken