Re: [PATCH v7 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-12 Thread Brenden Blanco
On Mon, Jul 11, 2016 at 11:17:00PM -0700, David Miller wrote: > From: Brenden Blanco > Date: Mon, 11 Jul 2016 14:29:51 -0700 > > > + if (priv->num_frags > 1) > > + return -EOPNOTSUPP; > > I hate to be the user who has to debug why his XDP program won't > load just because he set a ju

Re: [PATCH v7 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-11 Thread David Miller
From: Brenden Blanco Date: Mon, 11 Jul 2016 14:29:51 -0700 > + if (priv->num_frags > 1) > + return -EOPNOTSUPP; I hate to be the user who has to debug why his XDP program won't load just because he set a jumbo MTU beforehand.

[PATCH v7 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-11 Thread Brenden Blanco
Add support for the BPF_PROG_TYPE_XDP hook in mlx4 driver. In tc/socket bpf programs, helpers linearize skb fragments as needed when the program touches the packet data. However, in the pursuit of speed, XDP programs will not be allowed to use these slower functions, especially if it involves allo