Re: [PATCH v7 00/11] Add driver bpf hook for early packet drop and forwarding

2016-07-11 Thread Tom Herbert
On Mon, Jul 11, 2016 at 2:53 PM, Or Gerlitz wrote: > On Tue, Jul 12, 2016 at 12:29 AM, Brenden Blanco wrote: > >> v7: > [...] >> TODOs: >> Add ethtool per-ring stats for aborted, default cases, maybe even drop >> and tx as well. > > please no... lets stop and think if we can have something bet

Re: [PATCH v7 00/11] Add driver bpf hook for early packet drop and forwarding

2016-07-11 Thread Brenden Blanco
On Tue, Jul 12, 2016 at 12:53:34AM +0300, Or Gerlitz wrote: > On Tue, Jul 12, 2016 at 12:29 AM, Brenden Blanco wrote: > > > v7: > [...] > > TODOs: > > Add ethtool per-ring stats for aborted, default cases, maybe even drop > > and tx as well. > > please no... lets stop and think if we can have

Re: [PATCH v7 00/11] Add driver bpf hook for early packet drop and forwarding

2016-07-11 Thread Or Gerlitz
On Tue, Jul 12, 2016 at 12:29 AM, Brenden Blanco wrote: > v7: [...] > TODOs: > Add ethtool per-ring stats for aborted, default cases, maybe even drop > and tx as well. please no... lets stop and think if we can have something better vs every XDP enabled driver to have bunch of new ethtool bas

[PATCH v7 00/11] Add driver bpf hook for early packet drop and forwarding

2016-07-11 Thread Brenden Blanco
This patch set introduces new infrastructure for programmatically processing packets in the earliest stages of rx, as part of an effort others are calling eXpress Data Path (XDP) [1]. Start this effort by introducing a new bpf program type for early packet filtering, before even an skb has been all