Aw: Re: [PATCH v6 net-next 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-24 Thread Lino Sanfilippo
ot;Greg > Kroah-Hartman" , netdev@vger.kernel.org, > linux-ker...@vger.kernel.org, "Jakub Kicinski" , > devicet...@vger.kernel.org > Betreff: Re: [PATCH v6 net-next 17/17] net: qualcomm: add QCA7000 UART driver > > Am 23.05.2017 um 23:01 schrieb Lino Sanfilippo:

Re: [PATCH v6 net-next 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-24 Thread Stefan Wahren
Am 23.05.2017 um 23:01 schrieb Lino Sanfilippo: > On 23.05.2017 21:38, Stefan Wahren wrote: >>> Lino Sanfilippo hat am 23. Mai 2017 um 20:16 >>> geschrieben: >>> >>> I suggest to avoid this possible race by first unregistering the netdevice >>> and then >>> calling cancel_work_sync(). >> What m

Re: [PATCH v6 net-next 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-23 Thread Lino Sanfilippo
On 23.05.2017 21:38, Stefan Wahren wrote: > >> Lino Sanfilippo hat am 23. Mai 2017 um 20:16 >> geschrieben: >> >> >> Hi, >> >> On 23.05.2017 15:12, Stefan Wahren wrote: >> >> >>> +} >>> + >>> +static void qca_uart_remove(struct serdev_device *serdev) >>> +{ >>> + struct qcauart *qca = serdev_d

Re: [PATCH v6 net-next 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-23 Thread Stefan Wahren
> Lino Sanfilippo hat am 23. Mai 2017 um 20:16 > geschrieben: > > > Hi, > > On 23.05.2017 15:12, Stefan Wahren wrote: > > > > +} > > + > > +static void qca_uart_remove(struct serdev_device *serdev) > > +{ > > + struct qcauart *qca = serdev_device_get_drvdata(serdev); > > + > > + netif_c

Re: [PATCH v6 net-next 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-23 Thread Lino Sanfilippo
Hi, On 23.05.2017 15:12, Stefan Wahren wrote: > +} > + > +static void qca_uart_remove(struct serdev_device *serdev) > +{ > + struct qcauart *qca = serdev_device_get_drvdata(serdev); > + > + netif_carrier_off(qca->net_dev); > + cancel_work_sync(&qca->tx_work); > + unregister_netde

[PATCH v6 net-next 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-23 Thread Stefan Wahren
This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 16 + drivers/net/ethernet/qualcomm/Makefile| 2 + drivers/net/ethernet/qualcomm/qca_7k_common.h | 6 + drivers/