Re: [PATCH v6 net-next 14/19] ionic: Add initial ethtool support

2019-09-01 Thread Andrew Lunn
On Fri, Aug 30, 2019 at 03:16:41PM -0700, Jakub Kicinski wrote: > On Fri, 30 Aug 2019 14:25:12 -0700, Shannon Nelson wrote: > > On 8/29/19 4:10 PM, Jakub Kicinski wrote: > > > On Thu, 29 Aug 2019 11:27:15 -0700, Shannon Nelson wrote: > > >> +static int ionic_get_module_eeprom(struct net_device *n

Re: [PATCH v6 net-next 14/19] ionic: Add initial ethtool support

2019-08-30 Thread Jakub Kicinski
On Fri, 30 Aug 2019 14:25:12 -0700, Shannon Nelson wrote: > On 8/29/19 4:10 PM, Jakub Kicinski wrote: > > On Thu, 29 Aug 2019 11:27:15 -0700, Shannon Nelson wrote: > >> +static int ionic_get_module_eeprom(struct net_device *netdev, > >> + struct ethtool_eeprom *ee, > >

Re: [PATCH v6 net-next 14/19] ionic: Add initial ethtool support

2019-08-30 Thread Shannon Nelson
On 8/29/19 4:10 PM, Jakub Kicinski wrote: On Thu, 29 Aug 2019 11:27:15 -0700, Shannon Nelson wrote: +static int ionic_get_module_eeprom(struct net_device *netdev, + struct ethtool_eeprom *ee, + u8 *data) +{ + struct ionic_li

Re: [PATCH v6 net-next 14/19] ionic: Add initial ethtool support

2019-08-29 Thread Jakub Kicinski
On Thu, 29 Aug 2019 11:27:15 -0700, Shannon Nelson wrote: > +static int ionic_get_module_eeprom(struct net_device *netdev, > +struct ethtool_eeprom *ee, > +u8 *data) > +{ > + struct ionic_lif *lif = netdev_priv(netdev); > + str

[PATCH v6 net-next 14/19] ionic: Add initial ethtool support

2019-08-29 Thread Shannon Nelson
Add in the basic ethtool callbacks for device information and control. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/Makefile | 2 +- .../net/ethernet/pensando/ionic/ionic_dev.h | 7 + .../ethernet/pensando/ionic/ionic_ethtool.c | 494 ++ .../ethe