RE: [PATCH v6 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-06-14 Thread Ramesh Shanmugasundaram
Hi Ulrich, > Thanks for the patch, this is a lot easier to handle. > [...] > > +#define RCANFD_RFPTR_RFTS(x) (((x) >> 0) & 0xff) > > That should be "(((x) >> 0) & 0x)". > > > + [...] > > +/* RSCFDnCFDRMXXXq -> RCANFD_F_RMXXX(q) */ > > +#define RCANFD_F_RMID(q) (0x20

Re: [PATCH v6 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-06-13 Thread Ulrich Hecht
Thanks for the patch, this is a lot easier to handle. On Wed, Jun 8, 2016 at 8:38 AM, Ramesh Shanmugasundaram wrote: [...] > diff --git a/drivers/net/can/rcar/rcar_canfd.c > b/drivers/net/can/rcar/rcar_canfd.c > new file mode 100644 > index 000..9f1f513 > --- /dev/null > +++ b/drivers/net/ca

[PATCH v6 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-06-07 Thread Ramesh Shanmugasundaram
This patch adds support for the CAN FD controller found in Renesas R-Car SoCs. The controller operates in CAN FD only mode by default. CAN FD mode supports both Classical CAN & CAN FD frame formats. The controller supports ISO 11898-1:2015 CAN FD format only. This controller supports two channels