Re: [PATCH v5 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-28 Thread Thomas Graf
On 08/27/15 at 02:29pm, Pravin Shelar wrote: > On Thu, Aug 27, 2015 at 2:18 AM, Thomas Graf wrote: > > It is slightly non obvious that introducing an error condition above > > this and before udp_tun_rx_dst() would introduce a memory leak. Other > > than this looks great now. > > > I can not move

Re: [PATCH v5 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-27 Thread Pravin Shelar
On Thu, Aug 27, 2015 at 2:18 AM, Thomas Graf wrote: > On 08/26/15 at 11:46pm, Pravin B Shelar wrote: >> + if (ip_tunnel_collect_metadata() || geneve->collect_md) { >> + __be16 flags; >> + void *opts; >> + >> + flags = TUNNEL_KEY | TUNNEL_GENEVE_OPT | >> +

Re: [PATCH v5 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-27 Thread Thomas Graf
On 08/26/15 at 11:46pm, Pravin B Shelar wrote: > + if (ip_tunnel_collect_metadata() || geneve->collect_md) { > + __be16 flags; > + void *opts; > + > + flags = TUNNEL_KEY | TUNNEL_GENEVE_OPT | > + (gnvh->oam ? TUNNEL_OAM : 0) | > +

[PATCH v5 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-26 Thread Pravin B Shelar
Following patch create new tunnel flag which enable tunnel metadata collection on given device. These devices can be used by tunnel metadata based routing or by OVS. Geneve Consolidation patch get rid of collect_md_tun to simplify tunnel lookup further. Signed-off-by: Pravin B Shelar Reviewed-by: