Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-21 Thread Shay Agroskin
Lorenzo Bianconi writes: Lorenzo Bianconi writes: >> On Mon, 2020-12-07 at 17:32 +0100, Lorenzo Bianconi wrote: >> > Introduce xdp_shared_info data structure to contain info >> > about >> > "non-linear" xdp frame. xdp_shared_info will alias >> > skb_shared_info >> > allowing to keep most

Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-21 Thread Jamal Hadi Salim
On 2020-12-21 4:01 a.m., Jesper Dangaard Brouer wrote: On Sat, 19 Dec 2020 10:30:57 -0500 Sorry to interject: Does it make sense to use it to store arbitrary metadata or a scratchpad in this space? Something equivalent to skb->cb which is lacking in XDP. Well, XDP have the data_meta area. B

Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-21 Thread Jesper Dangaard Brouer
On Sat, 19 Dec 2020 10:30:57 -0500 Jamal Hadi Salim wrote: > On 2020-12-19 9:53 a.m., Shay Agroskin wrote: > > > > Lorenzo Bianconi writes: > > > > >> for the moment I do not know if this area is used for other purposes. > >> Do you think there are other use-cases for it? Yes, all the sa

Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-20 Thread Lorenzo Bianconi
> > > Lorenzo Bianconi writes: > > >> On Mon, 2020-12-07 at 17:32 +0100, Lorenzo Bianconi wrote: > >> > Introduce xdp_shared_info data structure to contain info > >> > about > >> > "non-linear" xdp frame. xdp_shared_info will alias > >> > skb_shared_info > >> > allowing to keep most of the frags i

Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-19 Thread Jamal Hadi Salim
On 2020-12-19 9:53 a.m., Shay Agroskin wrote: Lorenzo Bianconi writes: for the moment I do not know if this area is used for other purposes. Do you think there are other use-cases for it? Sorry to interject: Does it make sense to use it to store arbitrary metadata or a scratchpad in this

Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-19 Thread Shay Agroskin
Lorenzo Bianconi writes: On Mon, 2020-12-07 at 17:32 +0100, Lorenzo Bianconi wrote: > Introduce xdp_shared_info data structure to contain info > about > "non-linear" xdp frame. xdp_shared_info will alias > skb_shared_info > allowing to keep most of the frags in the same cache-line. [...]

Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-08 Thread Lorenzo Bianconi
> On Mon, 2020-12-07 at 17:32 +0100, Lorenzo Bianconi wrote: > > Introduce xdp_shared_info data structure to contain info about > > "non-linear" xdp frame. xdp_shared_info will alias skb_shared_info > > allowing to keep most of the frags in the same cache-line. > > Introduce some xdp_shared_info he

Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 17:32 +0100, Lorenzo Bianconi wrote: > Introduce xdp_shared_info data structure to contain info about > "non-linear" xdp frame. xdp_shared_info will alias skb_shared_info > allowing to keep most of the frags in the same cache-line. > Introduce some xdp_shared_info helpers alig

[PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-07 Thread Lorenzo Bianconi
Introduce xdp_shared_info data structure to contain info about "non-linear" xdp frame. xdp_shared_info will alias skb_shared_info allowing to keep most of the frags in the same cache-line. Introduce some xdp_shared_info helpers aligned to skb_frag* ones Signed-off-by: Lorenzo Bianconi --- driver