Re: [PATCH v5 4/4] net: diag: Support destroying TCP socketsr

2015-12-15 Thread Rustad, Mark D
Maciej Żenczykowski wrote: > I'd tend to agree that reset or abort would be preferable to destroy. > After all... the socket doesn't actually go away. Or maybe terminate? Reset kind of implies to me that it may resume operation. Abort could be ok. I think terminate is somewhat more neutral, if

Re: [PATCH v5 4/4] net: diag: Support destroying TCP socketsr

2015-12-15 Thread Maciej Żenczykowski
I'd tend to agree that reset or abort would be preferable to destroy. After all... the socket doesn't actually go away. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v5 4/4] net: diag: Support destroying TCP socketsr

2015-12-15 Thread David Miller
Please submit this with a proper "[PATCH vX 0/4] xxx" cover-letter. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 4/4] net: diag: Support destroying TCP socketsr

2015-12-15 Thread Lorenzo Colitti
Thanks for the reviews. This version fixes a few issues and addresses Tom's comments on v5. Specifically: 1. As requested by Tom, tcp_abort is no longer behind a config option, and now allows the caller to specify the error with which to interrupt blocking operations. (The SOCK_DIAG codep