Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-22 Thread Heiko Stübner
Am Donnerstag, 18. Juni 2020, 18:40:15 CEST schrieb Russell King - ARM Linux admin: > On Thu, Jun 18, 2020 at 06:01:29PM +0200, Heiko Stübner wrote: > > Am Donnerstag, 18. Juni 2020, 17:47:48 CEST schrieb Russell King - ARM > > Linux admin: > > > On Thu, Jun 18, 2020 at 05:41:54PM +0200, Heiko St

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread kernel test robot
Hi Heiko, I love your patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on sparc-next/master net-next/master net/master linus/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread Russell King - ARM Linux admin
On Thu, Jun 18, 2020 at 06:01:29PM +0200, Heiko Stübner wrote: > Am Donnerstag, 18. Juni 2020, 17:47:48 CEST schrieb Russell King - ARM Linux > admin: > > On Thu, Jun 18, 2020 at 05:41:54PM +0200, Heiko Stübner wrote: > > > Though I'm not sure how this fits in the whole bringup of ethernet phys. >

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread Heiko Stübner
Am Donnerstag, 18. Juni 2020, 17:47:48 CEST schrieb Russell King - ARM Linux admin: > On Thu, Jun 18, 2020 at 05:41:54PM +0200, Heiko Stübner wrote: > > Am Donnerstag, 18. Juni 2020, 15:41:02 CEST schrieb Russell King - ARM > > Linux admin: > > > On Thu, Jun 18, 2020 at 03:28:22PM +0200, Andrew L

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread Jakub Kicinski
On Thu, 18 Jun 2020 14:11:39 +0200 Heiko Stuebner wrote: > From: Heiko Stuebner > > At least VSC8530/8531/8540/8541 contain a clock output that can emit > a predefined rate of 25, 50 or 125MHz. > > This may then feed back into the network interface as source clock. > So expose a clock-provider f

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread Russell King - ARM Linux admin
On Thu, Jun 18, 2020 at 05:41:54PM +0200, Heiko Stübner wrote: > Am Donnerstag, 18. Juni 2020, 15:41:02 CEST schrieb Russell King - ARM Linux > admin: > > On Thu, Jun 18, 2020 at 03:28:22PM +0200, Andrew Lunn wrote: > > > On Thu, Jun 18, 2020 at 02:11:39PM +0200, Heiko Stuebner wrote: > > > > From

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread Heiko Stübner
Am Donnerstag, 18. Juni 2020, 15:41:02 CEST schrieb Russell King - ARM Linux admin: > On Thu, Jun 18, 2020 at 03:28:22PM +0200, Andrew Lunn wrote: > > On Thu, Jun 18, 2020 at 02:11:39PM +0200, Heiko Stuebner wrote: > > > From: Heiko Stuebner > > > > > > At least VSC8530/8531/8540/8541 contain a

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread Russell King - ARM Linux admin
On Thu, Jun 18, 2020 at 03:28:22PM +0200, Andrew Lunn wrote: > On Thu, Jun 18, 2020 at 02:11:39PM +0200, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > At least VSC8530/8531/8540/8541 contain a clock output that can emit > > a predefined rate of 25, 50 or 125MHz. > > > > This may then fe

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread Andrew Lunn
On Thu, Jun 18, 2020 at 02:11:39PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > At least VSC8530/8531/8540/8541 contain a clock output that can emit > a predefined rate of 25, 50 or 125MHz. > > This may then feed back into the network interface as source clock. > So expose a clock-pro

[PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread Heiko Stuebner
From: Heiko Stuebner At least VSC8530/8531/8540/8541 contain a clock output that can emit a predefined rate of 25, 50 or 125MHz. This may then feed back into the network interface as source clock. So expose a clock-provider from the phy using the common clock framework to allow setting the rate.