Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-08 Thread Eric Dumazet
On Mon, 2015-06-08 at 15:43 -0700, David Miller wrote: > From: Sergei Shtylyov > Date: Tue, 09 Jun 2015 01:41:12 +0300 > > > On 06/09/2015 01:19 AM, David Miller wrote: > > > >> It's completely implemented in software, you don't need to do anything > >> other than properly invoke napi_gro_receiv

Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-08 Thread David Miller
From: Sergei Shtylyov Date: Tue, 09 Jun 2015 01:41:12 +0300 > On 06/09/2015 01:19 AM, David Miller wrote: > >> It's completely implemented in software, you don't need to do anything >> other than properly invoke napi_gro_receive(). > >Not even set NETIF_F_GRO? Yes, you have to set that by

Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-08 Thread Sergei Shtylyov
On 06/09/2015 01:19 AM, David Miller wrote: Furthermore, you should pass the NAPI context into ravb_rx() and use I guess I should have one NAPI context per RX queue? Yes. Thanks, done. it so that you can invoke napi_gro_receive() on all of the packets and therefore support GRO.

Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-08 Thread David Miller
From: Sergei Shtylyov Date: Tue, 09 Jun 2015 00:44:16 +0300 > On 06/04/2015 06:12 AM, David Miller wrote: > >> Furthermore, you should pass the NAPI context into ravb_rx() and use > >I guess I should have one NAPI context per RX queue? Yes. > >> it so that you can invoke napi_gro_receive

Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-08 Thread Sergei Shtylyov
Hello. On 06/04/2015 06:12 AM, David Miller wrote: + /* Received network control queue */ + if (ris0 & RIS0_FRF1) { + ravb_write(ndev, ~RIS0_FRF1, RIS0); + /* Timestamp of network control packets that is based +

Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-03 Thread David Miller
From: Sergei Shtylyov Date: Tue, 02 Jun 2015 23:44:10 +0300 > + /* Received network control queue */ > + if (ris0 & RIS0_FRF1) { > + ravb_write(ndev, ~RIS0_FRF1, RIS0); > + /* Timestamp of network control packets that is based > +

[PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-02 Thread Sergei Shtylyov
Ethernet AVB includes an Gigabit Ethernet controller (E-MAC) that is basically compatible with SuperH Gigabit Ethernet E-MAC. Ethernet AVB has a dedicated direct memory access controller (AVB-DMAC) that is a new design compared to the SuperH E-DMAC. The AVB-DMAC is compliant with 3 standards for