Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

2016-09-26 Thread Bjorn Helgaas
On Sat, Sep 24, 2016 at 04:21:24PM -0700, Adit Ranadive wrote: > MAINTAINERS|9 + > drivers/infiniband/Kconfig |1 + > drivers/infiniband/hw/Makefile |1 + > drivers/infiniband/hw/pvrdma/Kconfig |7 +

Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

2016-09-26 Thread Adit Ranadive
On Mon, Sep 26, 2016 at 14:07:24PM -0700, Jason Gunthorpe wrote: > On Mon, Sep 26, 2016 at 01:40:10PM -0700, Adit Ranadive wrote: > > > Wouldnt they be some overlap between the user-space and kernel driver? Or is > > it expected that the common structures (even device specific ones) be moved > >

Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

2016-09-26 Thread Jason Gunthorpe
On Mon, Sep 26, 2016 at 01:40:10PM -0700, Adit Ranadive wrote: > Wouldnt they be some overlap between the user-space and kernel driver? Or is > it expected that the common structures (even device specific ones) be moved to > the ABI file? Yes, even device specific structures must be in the abi fi

Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

2016-09-26 Thread Adit Ranadive
On Mon, Sep 26, 2016 at 10:51:04AM -0600, Jason Gunthorpe wrote: > On Sun, Sep 25, 2016 at 10:25:12PM -0700, Adit Ranadive wrote: > > > As Jason said, you need a very good reason to split and create number of > > > files per-driver in UAPI folder. > > > > I can move the pvrdma-uapi.h back to the p

Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

2016-09-26 Thread Jason Gunthorpe
On Sun, Sep 25, 2016 at 10:25:12PM -0700, Adit Ranadive wrote: > > As Jason said, you need a very good reason to split and create number of > > files per-driver in UAPI folder. > > I can move the pvrdma-uapi.h back to the pvrdma driver folder. Just don't copy any of the content into your user spa

Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

2016-09-25 Thread Leon Romanovsky
On Sun, Sep 25, 2016 at 10:25:12PM -0700, Adit Ranadive wrote: > On Sun, Sep 25 2016 at 10:03:52AM +0300, Leon Romanovsky wrote: > > On Sat, Sep 24, 2016 at 04:21:24PM -0700, Adit Ranadive wrote: > > > > <...> > > > > > include/uapi/rdma/pvrdma-abi.h | 99 ++ > > > include/uapi/r

Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

2016-09-25 Thread Adit Ranadive
On Sun, Sep 25 2016 at 10:03:52AM +0300, Leon Romanovsky wrote: > On Sat, Sep 24, 2016 at 04:21:24PM -0700, Adit Ranadive wrote: > > <...> > > > include/uapi/rdma/pvrdma-abi.h | 99 ++ > > include/uapi/rdma/pvrdma-uapi.h| 255 + > > As Jason said, you need

Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

2016-09-25 Thread Leon Romanovsky
On Sat, Sep 24, 2016 at 04:21:24PM -0700, Adit Ranadive wrote: <...> > include/uapi/rdma/pvrdma-abi.h | 99 ++ > include/uapi/rdma/pvrdma-uapi.h| 255 + As Jason said, you need a very good reason to split and create number of files per-driver in UAPI folder

[PATCH v5 00/16] Add Paravirtual RDMA Driver

2016-09-24 Thread Adit Ranadive
Hi Doug, others, This patch series adds a driver for a paravirtual RDMA device. The device is developed for VMware's Virtual Machines and allows existing RDMA applications to continue to use existing Verbs API when deployed in VMs on ESXi. We recently did a presentation in the OFA Workshop [1] reg