From: Andy Gospodarek
Date: Tue, 25 Apr 2017 13:25:49 -0400
> On Mon, Apr 24, 2017 at 06:26:43PM -0400, David Miller wrote:
>> Andy, how goes it? :)
>
> Sorry for the delayed response. I was AFK yesterday, but based on
> testing from Friday and what I wrapped up today all looks good to me.
>
>
On Mon, Apr 24, 2017 at 06:26:43PM -0400, David Miller wrote:
> From: Jesper Dangaard Brouer
> Date: Mon, 24 Apr 2017 16:24:05 +0200
>
> > I've done a very detailed evaluation of this patch, and I've created a
> > blogpost like report here:
> >
> >
> > https://prototype-kernel.readthedocs.io/e
On Mon, 24 Apr 2017 18:26:43 -0400 (EDT)
David Miller wrote:
> From: Jesper Dangaard Brouer
> Date: Mon, 24 Apr 2017 16:24:05 +0200
>
> > I've done a very detailed evaluation of this patch, and I've created a
> > blogpost like report here:
> >
> >
> > https://prototype-kernel.readthedocs.io/
From: Jesper Dangaard Brouer
Date: Mon, 24 Apr 2017 16:24:05 +0200
> I've done a very detailed evaluation of this patch, and I've created a
> blogpost like report here:
>
>
> https://prototype-kernel.readthedocs.io/en/latest/blogposts/xdp25_eval_generic_xdp_tx.html
Thanks for doing this Jespe
I've done a very detailed evaluation of this patch, and I've created a
blogpost like report here:
https://prototype-kernel.readthedocs.io/en/latest/blogposts/xdp25_eval_generic_xdp_tx.html
I didn't evaluate the adjust_head part, so I hope Andy is still
planning to validate that part?
--Jesper
On Thu, 20 Apr 2017 16:30:34 +0200 Jesper Dangaard Brouer
wrote:
> On Wed, 19 Apr 2017 10:29:03 -0400
> Andy Gospodarek wrote:
>
> > I ran this on top of a card that uses the bnxt_en driver on a desktop
> > class system with an i7-6700 CPU @ 3.40GHz, sending a single stream of
> > UDP traffic
On Wed, Apr 19, 2017 at 09:40:49PM -0400, David Miller wrote:
> From: Andy Gospodarek
> Date: Wed, 19 Apr 2017 10:29:03 -0400
>
> > So I tried a variety of things and the simplest change on top of yours that
> > works well for xdp1, xdp2, and xdp_tx_iptunnel.
> >
> > diff --git a/net/core/dev.c
On Wed, 19 Apr 2017 10:29:03 -0400
Andy Gospodarek wrote:
> I ran this on top of a card that uses the bnxt_en driver on a desktop
> class system with an i7-6700 CPU @ 3.40GHz, sending a single stream of
> UDP traffic with flow control disabled and saw the following (all stats
> in Million PPS).
>
From: Andy Gospodarek
Date: Wed, 19 Apr 2017 10:29:03 -0400
> So I tried a variety of things and the simplest change on top of yours that
> works well for xdp1, xdp2, and xdp_tx_iptunnel.
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index b3d3a6e..1bab3dc 100644
> --- a/net/core/dev.c
> +
On Wed, Apr 19, 2017 at 04:25:43PM -0400, Andy Gospodarek wrote:
> On Wed, Apr 19, 2017 at 10:44:59AM -0700, John Fastabend wrote:
> > On 17-04-19 10:17 AM, Alexei Starovoitov wrote:
> > > On Wed, Apr 19, 2017 at 10:29:03AM -0400, Andy Gospodarek wrote:
> > >>
> > >> I ran this on top of a card tha
On Wed, Apr 19, 2017 at 10:44:59AM -0700, John Fastabend wrote:
> On 17-04-19 10:17 AM, Alexei Starovoitov wrote:
> > On Wed, Apr 19, 2017 at 10:29:03AM -0400, Andy Gospodarek wrote:
> >>
> >> I ran this on top of a card that uses the bnxt_en driver on a desktop
> >> class system with an i7-6700 CP
On 17-04-19 10:17 AM, Alexei Starovoitov wrote:
> On Wed, Apr 19, 2017 at 10:29:03AM -0400, Andy Gospodarek wrote:
>>
>> I ran this on top of a card that uses the bnxt_en driver on a desktop
>> class system with an i7-6700 CPU @ 3.40GHz, sending a single stream of
>> UDP traffic with flow control d
On Wed, Apr 19, 2017 at 10:29:03AM -0400, Andy Gospodarek wrote:
>
> I ran this on top of a card that uses the bnxt_en driver on a desktop
> class system with an i7-6700 CPU @ 3.40GHz, sending a single stream of
> UDP traffic with flow control disabled and saw the following (all stats
> in Million
On Tue, Apr 18, 2017 at 03:29:16PM -0400, David Miller wrote:
> From: David Miller
> Date: Tue, 18 Apr 2017 15:07:08 -0400 (EDT)
>
> > From: Andy Gospodarek
> > Date: Tue, 18 Apr 2017 15:05:35 -0400
> >
> >> On Fri, Apr 14, 2017 at 05:59:51PM -0700, Alexei Starovoitov wrote:
> >>> On Thu, Apr 1
On Tue, 18 Apr 2017 15:05:35 -0400 Andy Gospodarek wrote:
> On Fri, Apr 14, 2017 at 05:59:51PM -0700, Alexei Starovoitov wrote:
> > On Thu, Apr 13, 2017 at 04:23:15PM -0400, David Miller wrote:
> > > +
> > > + switch (act) {
> > > + case XDP_TX:
> > > + __skb_push(skb, skb->mac_len);
On Tue, Apr 18, 2017 at 03:29:16PM -0400, David Miller wrote:
> From: David Miller
> Date: Tue, 18 Apr 2017 15:07:08 -0400 (EDT)
>
> > From: Andy Gospodarek
> > Date: Tue, 18 Apr 2017 15:05:35 -0400
> >
> >> On Fri, Apr 14, 2017 at 05:59:51PM -0700, Alexei Starovoitov wrote:
> >>> On Thu, Apr 1
From: David Miller
Date: Tue, 18 Apr 2017 15:07:08 -0400 (EDT)
> From: Andy Gospodarek
> Date: Tue, 18 Apr 2017 15:05:35 -0400
>
>> On Fri, Apr 14, 2017 at 05:59:51PM -0700, Alexei Starovoitov wrote:
>>> On Thu, Apr 13, 2017 at 04:23:15PM -0400, David Miller wrote:
>>> > +
>>> > + switch (act)
From: Andy Gospodarek
Date: Tue, 18 Apr 2017 15:05:35 -0400
> On Fri, Apr 14, 2017 at 05:59:51PM -0700, Alexei Starovoitov wrote:
>> On Thu, Apr 13, 2017 at 04:23:15PM -0400, David Miller wrote:
>> > +
>> > + switch (act) {
>> > + case XDP_TX:
>> > + __skb_push(skb, skb->mac_len);
>>
On Fri, Apr 14, 2017 at 05:59:51PM -0700, Alexei Starovoitov wrote:
> On Thu, Apr 13, 2017 at 04:23:15PM -0400, David Miller wrote:
> > +
> > + switch (act) {
> > + case XDP_TX:
> > + __skb_push(skb, skb->mac_len);
>
> s/skb->mac_len/mac_len/
>
I was away from my keyboard for a few
On 4/14/17 6:59 PM, Alexei Starovoitov wrote:
> I'll test it next week unless people beat me to it.
>
I have run the xdp1 example from samples/bpf.
I have a patch that modifies set_link_xdp_fd to take a flags argument
which it adds to the request as the IFLA_XDP_FLAGS attribute. That's
used by c
On Thu, Apr 13, 2017 at 04:23:15PM -0400, David Miller wrote:
> +
> + switch (act) {
> + case XDP_TX:
> + __skb_push(skb, skb->mac_len);
s/skb->mac_len/mac_len/
> + HARD_TX_UNLOCK(dev, txq);
> + if (free_skb) {
> + trace_xdp_exception(dev, xdp_prog, XDP_TX)
On Thu, Apr 13, 2017 at 9:09 AM, David Miller wrote:
>
[snip]
> +static u32 netif_receive_generic_xdp(struct sk_buff *skb,
> +struct bpf_prog *xdp_prog)
> +{
> + struct xdp_buff xdp;
> + u32 act = XDP_DROP;
> + void *orig_data;
> + int
From: Michael Chan
Date: Thu, 13 Apr 2017 13:16:43 -0700
> On Thu, Apr 13, 2017 at 9:09 AM, David Miller wrote:
>>
>> ---
>>
>> v4:
>> - Fix MAC header adjustmnet before calling prog (David Ahern)
>> - Disable LRO when generic XDP is installed (Michael Chan)
>
> I don't see where you are disa
On Thu, Apr 13, 2017 at 9:09 AM, David Miller wrote:
>
> ---
>
> v4:
> - Fix MAC header adjustmnet before calling prog (David Ahern)
> - Disable LRO when generic XDP is installed (Michael Chan)
I don't see where you are disabling LRO in the patch.
> - Bypass qdisc et al. on XDP_TX and record
This provides a generic SKB based non-optimized XDP path which is used
if either the driver lacks a specific XDP implementation, or the user
requests it via a new IFLA_XDP_FLAGS value named XDP_FLAGS_SKB_MODE.
It is arguable that perhaps I should have required something like
this as part of the i
25 matches
Mail list logo
