Re: [PATCH v4 net-next 3/5] net: dsa: Link aggregation support

2020-12-17 Thread Vladimir Oltean
On Wed, Dec 16, 2020 at 09:09:58PM +0100, Tobias Waldekranz wrote: > On Wed, Dec 16, 2020 at 20:44, Vladimir Oltean wrote: > > On Wed, Dec 16, 2020 at 05:00:54PM +0100, Tobias Waldekranz wrote: > >> diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c > >> index 183003e45762..deee4c0ecb31 100644 > >> ---

Re: [PATCH v4 net-next 3/5] net: dsa: Link aggregation support

2020-12-16 Thread Tobias Waldekranz
On Wed, Dec 16, 2020 at 20:44, Vladimir Oltean wrote: > On Wed, Dec 16, 2020 at 05:00:54PM +0100, Tobias Waldekranz wrote: >> diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c >> index 183003e45762..deee4c0ecb31 100644 >> --- a/net/dsa/dsa2.c >> +++ b/net/dsa/dsa2.c >> @@ -21,6 +21,46 @@ >> static DEF

Re: [PATCH v4 net-next 3/5] net: dsa: Link aggregation support

2020-12-16 Thread Tobias Waldekranz
On Wed, Dec 16, 2020 at 20:02, Vladimir Oltean wrote: > On Wed, Dec 16, 2020 at 05:00:54PM +0100, Tobias Waldekranz wrote: >> +/* Drivers that benefit from having an ID associated with each >> + * offloaded LAG should set this to the maximum number of >> + * supported IDs. DSA will the

Re: [PATCH v4 net-next 3/5] net: dsa: Link aggregation support

2020-12-16 Thread Tobias Waldekranz
On Wed, Dec 16, 2020 at 18:22, Vladimir Oltean wrote: > On Wed, Dec 16, 2020 at 05:00:54PM +0100, Tobias Waldekranz wrote: >> Monitor the following events and notify the driver when: >> >> - A DSA port joins/leaves a LAG. >> - A LAG, made up of DSA ports, joins/leaves a bridge. >> - A DSA port in

Re: [PATCH v4 net-next 3/5] net: dsa: Link aggregation support

2020-12-16 Thread Vladimir Oltean
On Wed, Dec 16, 2020 at 05:00:54PM +0100, Tobias Waldekranz wrote: > diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c > index 183003e45762..deee4c0ecb31 100644 > --- a/net/dsa/dsa2.c > +++ b/net/dsa/dsa2.c > @@ -21,6 +21,46 @@ > static DEFINE_MUTEX(dsa2_mutex); > LIST_HEAD(dsa_tree_list); > > +void d

Re: [PATCH v4 net-next 3/5] net: dsa: Link aggregation support

2020-12-16 Thread Vladimir Oltean
On Wed, Dec 16, 2020 at 05:00:54PM +0100, Tobias Waldekranz wrote: > + /* Drivers that benefit from having an ID associated with each > + * offloaded LAG should set this to the maximum number of > + * supported IDs. DSA will then maintain a mapping of _at > + * least_ these many

Re: [PATCH v4 net-next 3/5] net: dsa: Link aggregation support

2020-12-16 Thread Vladimir Oltean
On Wed, Dec 16, 2020 at 05:00:54PM +0100, Tobias Waldekranz wrote: > Monitor the following events and notify the driver when: > > - A DSA port joins/leaves a LAG. > - A LAG, made up of DSA ports, joins/leaves a bridge. > - A DSA port in a LAG is enabled/disabled (enabled meaning > "distributing"

[PATCH v4 net-next 3/5] net: dsa: Link aggregation support

2020-12-16 Thread Tobias Waldekranz
Monitor the following events and notify the driver when: - A DSA port joins/leaves a LAG. - A LAG, made up of DSA ports, joins/leaves a bridge. - A DSA port in a LAG is enabled/disabled (enabled meaning "distributing" in 802.3ad LACP terms). When a LAG joins a bridge, the DSA subsystem will tre