Re: [PATCH v4 net-next 2/5] net: page_pool: add bulk support for ptr_ring

2020-11-10 Thread Jesper Dangaard Brouer
On Fri, 6 Nov 2020 19:19:08 +0100 Lorenzo Bianconi wrote: > Introduce the capability to batch page_pool ptr_ring refill since it is > usually run inside the driver NAPI tx completion loop. > > Suggested-by: Jesper Dangaard Brouer > Signed-off-by: Lorenzo Bianconi > --- > include/net/page_poo

Re: [PATCH v4 net-next 2/5] net: page_pool: add bulk support for ptr_ring

2020-11-07 Thread Lorenzo Bianconi
> On Fri, 6 Nov 2020 19:19:08 +0100 > Lorenzo Bianconi wrote: > [...] > > I don't like this comment. This function is also used by non-bulking > case. Reaching this point means the page is ready or fulfill the > requirement for being recycled into the ptr_ring. > > I suggest (as before): >

Re: [PATCH v4 net-next 2/5] net: page_pool: add bulk support for ptr_ring

2020-11-06 Thread Jesper Dangaard Brouer
On Fri, 6 Nov 2020 19:19:08 +0100 Lorenzo Bianconi wrote: > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index ef98372facf6..31dac2ad4a1f 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -11,6 +11,8 @@ > #include > > #include > +#include > + > #include

[PATCH v4 net-next 2/5] net: page_pool: add bulk support for ptr_ring

2020-11-06 Thread Lorenzo Bianconi
Introduce the capability to batch page_pool ptr_ring refill since it is usually run inside the driver NAPI tx completion loop. Suggested-by: Jesper Dangaard Brouer Signed-off-by: Lorenzo Bianconi --- include/net/page_pool.h | 26 net/core/page_pool.c| 66 +++