Re: [PATCH v4 net-next 1/2] ipv4: L3 hash-based multipath

2015-09-23 Thread Peter Nørlund
On Wed, 23 Sep 2015 16:12:42 -0700 Tom Herbert wrote: > On Wed, Sep 23, 2015 at 2:43 PM, Peter Nørlund > wrote: > > On Wed, 23 Sep 2015 14:00:43 -0700 > > Tom Herbert wrote: > > > >> On Wed, Sep 23, 2015 at 12:49 PM, Peter Nørlund > >> wrote: > >> > Replaces the per-packet multipath with a has

Re: [PATCH v4 net-next 1/2] ipv4: L3 hash-based multipath

2015-09-23 Thread Tom Herbert
On Wed, Sep 23, 2015 at 4:09 PM, Peter Nørlund wrote: > On Wed, 23 Sep 2015 14:00:43 -0700 > Tom Herbert wrote: > >> On Wed, Sep 23, 2015 at 12:49 PM, Peter Nørlund >> wrote: >> > Replaces the per-packet multipath with a hash-based multipath using >> > source and destination address. >> > >> It'

Re: [PATCH v4 net-next 1/2] ipv4: L3 hash-based multipath

2015-09-23 Thread Tom Herbert
On Wed, Sep 23, 2015 at 2:43 PM, Peter Nørlund wrote: > On Wed, 23 Sep 2015 14:00:43 -0700 > Tom Herbert wrote: > >> On Wed, Sep 23, 2015 at 12:49 PM, Peter Nørlund >> wrote: >> > Replaces the per-packet multipath with a hash-based multipath using >> > source and destination address. >> > >> It'

Re: [PATCH v4 net-next 1/2] ipv4: L3 hash-based multipath

2015-09-23 Thread Peter Nørlund
On Wed, 23 Sep 2015 14:00:43 -0700 Tom Herbert wrote: > On Wed, Sep 23, 2015 at 12:49 PM, Peter Nørlund > wrote: > > Replaces the per-packet multipath with a hash-based multipath using > > source and destination address. > > > It's good that round robin is going away, but this still looks very >

Re: [PATCH v4 net-next 1/2] ipv4: L3 hash-based multipath

2015-09-23 Thread David Miller
From: Peter Nørlund Date: Wed, 23 Sep 2015 21:49:36 +0200 > +static inline int fib_multipath_hash(__be32 saddr, __be32 daddr) > +{ > + return jhash_2words(saddr, daddr, fib_multipath_secret) >> 1; > +} Like Tom I'm curious why you do this shift here? -- To unsubscribe from this list: send th

Re: [PATCH v4 net-next 1/2] ipv4: L3 hash-based multipath

2015-09-23 Thread Peter Nørlund
On Wed, 23 Sep 2015 14:00:43 -0700 Tom Herbert wrote: > On Wed, Sep 23, 2015 at 12:49 PM, Peter Nørlund > wrote: > > Replaces the per-packet multipath with a hash-based multipath using > > source and destination address. > > > It's good that round robin is going away, but this still looks very >

Re: [PATCH v4 net-next 1/2] ipv4: L3 hash-based multipath

2015-09-23 Thread Tom Herbert
On Wed, Sep 23, 2015 at 12:49 PM, Peter Nørlund wrote: > Replaces the per-packet multipath with a hash-based multipath using > source and destination address. > It's good that round robin is going away, but this still looks very different with how multipath routing is done done in IPv6 (rt6_multip

[PATCH v4 net-next 1/2] ipv4: L3 hash-based multipath

2015-09-23 Thread Peter Nørlund
Replaces the per-packet multipath with a hash-based multipath using source and destination address. Signed-off-by: Peter Nørlund --- include/net/ip_fib.h | 14 - net/ipv4/fib_semantics.c | 140 +- net/ipv4/route.c | 16 -- 3 fi