Re: [PATCH v4 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-14 Thread Vladimir Oltean
On Thu, Jan 14, 2021 at 09:19:43AM -0800, Jakub Kicinski wrote: > On Thu, 14 Jan 2021 12:27:43 +0200 Vladimir Oltean wrote: > > On Wed, Jan 13, 2021 at 07:30:33PM -0800, Jakub Kicinski wrote: > > > On Mon, 11 Jan 2021 19:43:14 +0200 Vladimir Oltean wrote: > > > > +struct ocelot_devlink_private { >

Re: [PATCH v4 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-14 Thread Jakub Kicinski
On Thu, 14 Jan 2021 12:27:43 +0200 Vladimir Oltean wrote: > On Wed, Jan 13, 2021 at 07:30:33PM -0800, Jakub Kicinski wrote: > > On Mon, 11 Jan 2021 19:43:14 +0200 Vladimir Oltean wrote: > > > +struct ocelot_devlink_private { > > > + struct ocelot *ocelot; > > > +}; > > > > I don't think you ev

Re: [PATCH v4 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-14 Thread Vladimir Oltean
On Wed, Jan 13, 2021 at 07:30:33PM -0800, Jakub Kicinski wrote: > On Mon, 11 Jan 2021 19:43:14 +0200 Vladimir Oltean wrote: > > +struct ocelot_devlink_private { > > + struct ocelot *ocelot; > > +}; > > I don't think you ever explained to me why you don't put struct ocelot > in the priv. > > -

Re: [PATCH v4 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-13 Thread Jakub Kicinski
On Mon, 11 Jan 2021 19:43:14 +0200 Vladimir Oltean wrote: > +struct ocelot_devlink_private { > + struct ocelot *ocelot; > +}; I don't think you ever explained to me why you don't put struct ocelot in the priv. - ocelot = devm_kzalloc(&pdev->dev, sizeof(*ocelot), GFP_KERNEL); - if

[PATCH v4 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-11 Thread Vladimir Oltean
From: Vladimir Oltean Add devlink integration into the mscc_ocelot switchdev driver. All physical ports (i.e. the unused ones as well) except the CPU port module at ocelot->num_phys_ports are registered with devlink, and that requires keeping the devlink_port structure outside struct ocelot_port_