Re: [PATCH v4 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-02-21 Thread Boris Pismenny
On 17/02/2021 15:55, Or Gerlitz wrote: > On Sun, Feb 14, 2021 at 8:20 PM David Ahern wrote: >> On 2/11/21 2:10 PM, Boris Pismenny wrote: >>> @@ -223,6 +229,164 @@ static inline size_t nvme_tcp_pdu_last_send(struct >>> nvme_tcp_request *req, >>> return nvme_tcp_pdu_data_left(req) <= len; >>>

Re: [PATCH v4 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-02-17 Thread Or Gerlitz
On Sun, Feb 14, 2021 at 8:20 PM David Ahern wrote: > On 2/11/21 2:10 PM, Boris Pismenny wrote: > > @@ -223,6 +229,164 @@ static inline size_t nvme_tcp_pdu_last_send(struct > > nvme_tcp_request *req, > > return nvme_tcp_pdu_data_left(req) <= len; > > } > > > > +#ifdef CONFIG_TCP_DDP > > + >

Re: [PATCH v4 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-02-14 Thread Or Gerlitz
On Sun, Feb 14, 2021 at 8:20 PM David Ahern wrote: > On 2/11/21 2:10 PM, Boris Pismenny wrote: > > @@ -223,6 +229,164 @@ static inline size_t nvme_tcp_pdu_last_send(struct > > nvme_tcp_request *req, > > return nvme_tcp_pdu_data_left(req) <= len; > > } Hi Dave, Thanks for the continuous f

Re: [PATCH v4 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-02-14 Thread David Ahern
On 2/11/21 2:10 PM, Boris Pismenny wrote: > @@ -223,6 +229,164 @@ static inline size_t nvme_tcp_pdu_last_send(struct > nvme_tcp_request *req, > return nvme_tcp_pdu_data_left(req) <= len; > } > > +#ifdef CONFIG_TCP_DDP > + > +static bool nvme_tcp_resync_request(struct sock *sk, u32 seq, u3

[PATCH v4 net-next 06/21] nvme-tcp: Add DDP offload control path

2021-02-11 Thread Boris Pismenny
This commit introduces direct data placement offload to NVME TCP. There is a context per queue, which is established after the handshake using the tcp_ddp_sk_add/del NDOs. Additionally, a resynchronization routine is used to assist hardware recovery from TCP OOO, and continue the offload. Resynchr