Re: [PATCH v4 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-03 Thread Raju Lakkaraju
Hi Andrew, On Mon, Oct 03, 2016 at 09:56:56AM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > > > +vsc8531_0: ethernet-phy@0 { > > > > +compatible = "ethernet-phy-id0007.0570"; > > > > +vsc8531,vddmac = /bits/ 16 > > > > ; > > > > +

Re: [PATCH v4 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-03 Thread Andrew Lunn
> > > +vsc8531_0: ethernet-phy@0 { > > > +compatible = "ethernet-phy-id0007.0570"; > > > +vsc8531,vddmac = /bits/ 16 > > > ; > > > +vsc8531,edge-slowdown= /bits/ 8 <17>; > > > > No, real values please: > > > >

Re: [PATCH v4 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-03 Thread Raju Lakkaraju
Hi Andrew, Thank you for code review and valuable comments. On Wed, Sep 28, 2016 at 06:16:53PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > +Optional properties: > > +- vsc8531,vddmac : The vddmac in mV. > > +- vsc8531,edge-slowdown : % the edge should be slowed down relative to

Re: [PATCH v4 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-28 Thread Andrew Lunn
> +Optional properties: > +- vsc8531,vddmac : The vddmac in mV. > +- vsc8531,edge-slowdown : % the edge should be slowed down relative to > + the fastest possible edge time. Native sign > + need not enter. > + Edge rate sets

[PATCH v4 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-09-28 Thread Raju Lakkaraju
From: Raju Lakkaraju Edge-rate: As system and networking speeds increase, a signal's output transition, also know as the edge rate or slew rate (V/ns), takes on greater importance because high-speed signals come with a price. That price is an assortment of interference problems like ringing on th