Re: [PATCH v4 net] rtnetlink: Fix memory(net_device) leak when ->newlink fails

2020-07-15 Thread Weilong Chen
On 2020/7/15 13:45, Cong Wang wrote: > On Tue, Jul 14, 2020 at 6:27 PM Weilong Chen wrote: >> >> When vlan_newlink call register_vlan_dev fails, it might return error >> with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should >> free the memory. But currently rtnl_newlink only free the

Re: [PATCH v4 net] rtnetlink: Fix memory(net_device) leak when ->newlink fails

2020-07-14 Thread Cong Wang
On Tue, Jul 14, 2020 at 6:27 PM Weilong Chen wrote: > > When vlan_newlink call register_vlan_dev fails, it might return error > with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should > free the memory. But currently rtnl_newlink only free the memory which > state is NETREG_UNINITIALIZE

[PATCH v4 net] rtnetlink: Fix memory(net_device) leak when ->newlink fails

2020-07-14 Thread Weilong Chen
When vlan_newlink call register_vlan_dev fails, it might return error with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should free the memory. But currently rtnl_newlink only free the memory which state is NETREG_UNINITIALIZED. BUG: memory leak unreferenced object 0x8881051de000 (si