Re: [PATCH v4 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval'

2016-09-27 Thread Maciej Żenczykowski
> Good point. Using ms should actually be easy, instead of > proc_dointvec_jiffies you can use proc_dointvec_ms_jiffies. Yes, I'm aware of this, but 'proc_dointvec_ms_jiffies' seems to be a bit of a hack, and especially for large settings like this exporting them to userspace in units of ms instea

Re: [PATCH v4 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval'

2016-09-27 Thread Hannes Frederic Sowa
On 27.09.2016 04:30, Maciej Żenczykowski wrote: >> Is seconds granular enough? > > The only reason why one would ever want to go into fractions of > seconds would be some sort of unittesting with very low delays. > > In any normal environment the max is going to be tens if not hundreds > or thous

Re: [PATCH v4 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval'

2016-09-26 Thread Maciej Żenczykowski
> Is seconds granular enough? The only reason why one would ever want to go into fractions of seconds would be some sort of unittesting with very low delays. In any normal environment the max is going to be tens if not hundreds or thousands of seconds. Also note that the delay and interval (ie.

Re: [PATCH v4 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval'

2016-09-26 Thread Hannes Frederic Sowa
On 25.09.2016 13:03, Maciej Żenczykowski wrote: > + .procname = "router_solicitation_max_interval", > + .data = &ipv6_devconf.rtr_solicit_max_interval, > + .maxlen = sizeof(int), > + .mode = 0644, > + .pro

Re: [PATCH v4 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval'

2016-09-26 Thread Erik Kline
On 25 September 2016 at 20:03, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > Accessible via: > /proc/sys/net/ipv6/conf/*/router_solicitation_max_interval > > For now we default it to the same value as the normal interval. > > Signed-off-by: Maciej Żenczykowski > --- > include/lin

[PATCH v4 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval'

2016-09-25 Thread Maciej Żenczykowski
From: Maciej Żenczykowski Accessible via: /proc/sys/net/ipv6/conf/*/router_solicitation_max_interval For now we default it to the same value as the normal interval. Signed-off-by: Maciej Żenczykowski --- include/linux/ipv6.h | 1 + include/net/addrconf.h| 1 + include/uapi/linux/