Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework

2019-01-22 Thread Wolfgang Grandegger
Hello Dan, Am 22.01.19 um 14:04 schrieb Dan Murphy: > Wolfgang > > Thanks for the review > > On 1/22/19 2:16 AM, Wolfgang Grandegger wrote: >> Hello Dan, >> >> looks already quite good... >> >> Am 17.01.19 um 21:05 schrieb Dan Murphy: >>> Create a m_can platform framework that peripherial >>> de

Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework

2019-01-22 Thread Dan Murphy
Wolfgang Thanks for the review On 1/22/19 2:16 AM, Wolfgang Grandegger wrote: > Hello Dan, > > looks already quite good... > > Am 17.01.19 um 21:05 schrieb Dan Murphy: >> Create a m_can platform framework that peripherial >> devices can register to and use common code and register sets. >> The

Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework

2019-01-22 Thread Wolfgang Grandegger
Hello Dan, looks already quite good... Am 17.01.19 um 21:05 schrieb Dan Murphy: > Create a m_can platform framework that peripherial > devices can register to and use common code and register sets. > The peripherial devices may provide read/write and configuration > support of the IP. > > Signed

Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework

2019-01-18 Thread Dan Murphy
Wolfgang On 1/18/19 12:56 AM, Wolfgang Grandegger wrote: > Hello Dan, > > Am 17.01.19 um 21:08 schrieb Dan Murphy: >> Wolfgang >> >> On 1/17/19 2:05 PM, Dan Murphy wrote: >>> Create a m_can platform framework that peripherial >>> devices can register to and use common code and register sets. >>>

Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework

2019-01-17 Thread Wolfgang Grandegger
Hello Dan, Am 17.01.19 um 21:08 schrieb Dan Murphy: > Wolfgang > > On 1/17/19 2:05 PM, Dan Murphy wrote: >> Create a m_can platform framework that peripherial >> devices can register to and use common code and register sets. >> The peripherial devices may provide read/write and configuration >> s

Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework

2019-01-17 Thread Dan Murphy
Wolfgang On 1/17/19 2:05 PM, Dan Murphy wrote: > Create a m_can platform framework that peripherial > devices can register to and use common code and register sets. > The peripherial devices may provide read/write and configuration > support of the IP. > > Signed-off-by: Dan Murphy > --- > driv

[PATCH v4 1/4] can: m_can: Create a m_can platform framework

2019-01-17 Thread Dan Murphy
Create a m_can platform framework that peripherial devices can register to and use common code and register sets. The peripherial devices may provide read/write and configuration support of the IP. Signed-off-by: Dan Murphy --- drivers/net/can/m_can/m_can.c | 6 + drivers/net/can/m_ca