Re: [PATCH v4 1/2] geneve: implement support for IPv6-based tunnels

2015-10-21 Thread John W. Linville
On Wed, Oct 21, 2015 at 10:52:43AM +0900, YOSHIFUJI Hideaki/吉藤英明 wrote: > Hi, Yoshifuji-san -- thank you for taking a look at my proposed patch! > John W. Linville wrote: > > Signed-off-by: John W. Linville > > --- > > v4: > > - treat mode field of ip_tunnel_info as flags > > - add a missing IS_

Re: [PATCH v4 1/2] geneve: implement support for IPv6-based tunnels

2015-10-20 Thread Jesse Gross
All of this looks pretty good to me, I just have a few last things that I noticed: On Tue, Oct 20, 2015 at 11:11 PM, John W. Linville wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 8f5c02eed47d..217b472ab9e7 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve

Re: [PATCH v4 1/2] geneve: implement support for IPv6-based tunnels

2015-10-20 Thread YOSHIFUJI Hideaki/吉藤英明
Hi, John W. Linville wrote: > Signed-off-by: John W. Linville > --- > v4: > - treat mode field of ip_tunnel_info as flags > - add a missing IS_ENABLED(CONFIG_IPV6) to geneve_rx > - remove unneeded flags field in geneve_dev > - NULL-check parameter for __geneve_sock_release > - check remote socket

Re: [PATCH v4 1/2] geneve: implement support for IPv6-based tunnels

2015-10-20 Thread kbuild test robot
Hi John, [auto build test WARNING on v4.3-rc6 -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/John-W-Linville/geneve-implement-support-for-IPv6-based-tunnels/20151020-232128 config: x86_64-randconfig-a0-1

[PATCH v4 1/2] geneve: implement support for IPv6-based tunnels

2015-10-20 Thread John W. Linville
Signed-off-by: John W. Linville --- v4: - treat mode field of ip_tunnel_info as flags - add a missing IS_ENABLED(CONFIG_IPV6) to geneve_rx - remove unneeded flags field in geneve_dev - NULL-check parameter for __geneve_sock_release - check remote socket family for AF_UNSPEC in geneve_configure - r