Re: [PATCH v4 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-08 Thread Feng Gao
Ok, I have sent the v5 patch with two updates: 1. One is make fixed_header of gre_full_header as uname struct; 2. Use one macro instead of the key literal master htonl(0x); The v5 link is https://www.mail-archive.com/netdev@vger.kernel.org/msg122261.html. But I don't know what's advantage wit

Re: [PATCH v4 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-08 Thread Philp Prindeville
No, I was referring to anonymous structures, which is a feature of C11. Please see the link I sent. On 08/08/2016 03:13 AM, Feng Gao wrote: Hi Philip, Do you mean like the following? struct gre_full_hdr { struct { __be16 flags; __be16 protocol;

Re: [PATCH v4 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-08 Thread Feng Gao
Hi Philip, Do you mean like the following? struct gre_full_hdr { struct { __be16 flags; __be16 protocol; } fixed_header; __be16 csum; __be16 reserved1; __be32 key; __be32 seq; } __packed; But we need struct gre_base_

Re: [PATCH v4 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-07 Thread Philp Prindeville
Feng, An anonymous structure is defined here: https://gcc.gnu.org/onlinedocs/gcc/Unnamed-Fields.html i.e.: struct gre_full_hdr { struct gre_base_hdr; ... so yes, I'm talking about making fixed_header be anonymous instead. -Philip On 08/07/2016 08:50 PM, Feng Gao wrote: Hi Philp,

Re: [PATCH v4 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-07 Thread Feng Gao
Hi Philp, Forgive my poor English, I am not clear about the comment #1. "Can you make gre_base_hdr be anonymous?". +struct gre_full_hdr { + struct gre_base_hdr fixed_header; Do you mean make the member "fixed_header" as anonymous or not? Best Regards Feng On Mon, Aug 8, 2016 at 5:03 AM, Phi

Re: [PATCH v4 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-07 Thread Philp Prindeville
Inline... On 08/04/2016 01:06 AM, f...@48lvckh6395k16k5.yundunddos.com wrote: From: Gao Feng The PPTP is encapsulated by GRE header with that GRE_VERSION bits must contain one. But current GRE RPS needs the GRE_VERSION must be zero. So RPS does not work for PPTP traffic. In my test environme

[PATCH v4 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-04 Thread fgao
From: Gao Feng The PPTP is encapsulated by GRE header with that GRE_VERSION bits must contain one. But current GRE RPS needs the GRE_VERSION must be zero. So RPS does not work for PPTP traffic. In my test environment, there are four MIPS cores, and all traffic are passed through by PPTP. As a re