Re: [PATCH v4 1/1] can: dev: add software tx timestamps

2021-01-13 Thread Marc Kleine-Budde
On 1/13/21 2:48 AM, Jakub Kicinski wrote: >> Please make sure to address the warnings before this hits net-next: >> >> https://patchwork.kernel.org/project/netdevbpf/patch/20210112130538.14912-2-mailhol.vinc...@wanadoo.fr/ >> >> Actually it appears not to build with allmodconfig..? > > Erm, apolog

Re: [PATCH v4 1/1] can: dev: add software tx timestamps

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 17:46:25 -0800 Jakub Kicinski wrote: > On Tue, 12 Jan 2021 11:03:00 +0100 Marc Kleine-Budde wrote: > > On 1/12/21 10:54 AM, Vincent Mailhol wrote: > > > Call skb_tx_timestamp() within can_put_echo_skb() so that a software > > > tx timestamp gets attached on the skb. > > > > >

Re: [PATCH v4 1/1] can: dev: add software tx timestamps

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 11:03:00 +0100 Marc Kleine-Budde wrote: > On 1/12/21 10:54 AM, Vincent Mailhol wrote: > > Call skb_tx_timestamp() within can_put_echo_skb() so that a software > > tx timestamp gets attached on the skb. > > > > There two main reasons to include this call in can_put_echo_skb(): >

Re: [PATCH v4 1/1] can: dev: add software tx timestamps

2021-01-12 Thread Marc Kleine-Budde
On 1/12/21 10:54 AM, Vincent Mailhol wrote: > Call skb_tx_timestamp() within can_put_echo_skb() so that a software > tx timestamp gets attached on the skb. > > There two main reasons to include this call in can_put_echo_skb(): > > * It easily allow to enable the tx timestamp on all devices with

[PATCH v4 1/1] can: dev: add software tx timestamps

2021-01-12 Thread Vincent Mailhol
Call skb_tx_timestamp() within can_put_echo_skb() so that a software tx timestamp gets attached on the skb. There two main reasons to include this call in can_put_echo_skb(): * It easily allow to enable the tx timestamp on all devices with just one small change. * According to Documentat