Re: [PATCH v4 02/11] fs: Move __scm_install_fd() to __fd_install_received()

2020-06-18 Thread Kees Cook
On Thu, Jun 18, 2020 at 10:56:14AM +0200, Christian Brauner wrote: > On Mon, Jun 15, 2020 at 08:25:15PM -0700, Kees Cook wrote: > > In preparation for users of the "install a received file" logic outside > > of net/ (pidfd and seccomp), relocate and rename __scm_install_fd() from > > net/core/scm.c

Re: [PATCH v4 02/11] fs: Move __scm_install_fd() to __fd_install_received()

2020-06-18 Thread Christian Brauner
On Mon, Jun 15, 2020 at 08:25:15PM -0700, Kees Cook wrote: > In preparation for users of the "install a received file" logic outside > of net/ (pidfd and seccomp), relocate and rename __scm_install_fd() from > net/core/scm.c to __fd_install_received() in fs/file.c, and provide a > wrapper named fd_

Re: [PATCH v4 02/11] fs: Move __scm_install_fd() to __fd_install_received()

2020-06-17 Thread Kees Cook
On Wed, Jun 17, 2020 at 03:25:41PM +, David Laight wrote: > From: Kees Cook > > Sent: 16 June 2020 04:25 > > > In preparation for users of the "install a received file" logic outside > > of net/ (pidfd and seccomp), relocate and rename __scm_install_fd() from > > net/core/scm.c to __fd_instal

RE: [PATCH v4 02/11] fs: Move __scm_install_fd() to __fd_install_received()

2020-06-17 Thread David Laight
From: Kees Cook > Sent: 16 June 2020 04:25 > In preparation for users of the "install a received file" logic outside > of net/ (pidfd and seccomp), relocate and rename __scm_install_fd() from > net/core/scm.c to __fd_install_received() in fs/file.c, and provide a > wrapper named fd_install_receiv

Re: [PATCH v4 02/11] fs: Move __scm_install_fd() to __fd_install_received()

2020-06-15 Thread Kees Cook
On Tue, Jun 16, 2020 at 05:29:41AM +, Sargun Dhillon wrote: > On Mon, Jun 15, 2020 at 08:25:15PM -0700, Kees Cook wrote: > > +/** > > + * __fd_install_received() - Install received file into file descriptor > > table > > + * > > + * @fd: fd to install into (if negative, a new fd will be alloca

Re: [PATCH v4 02/11] fs: Move __scm_install_fd() to __fd_install_received()

2020-06-15 Thread Sargun Dhillon
On Mon, Jun 15, 2020 at 08:25:15PM -0700, Kees Cook wrote: > In preparation for users of the "install a received file" logic outside > of net/ (pidfd and seccomp), relocate and rename __scm_install_fd() from > net/core/scm.c to __fd_install_received() in fs/file.c, and provide a > wrapper named fd_

[PATCH v4 02/11] fs: Move __scm_install_fd() to __fd_install_received()

2020-06-15 Thread Kees Cook
In preparation for users of the "install a received file" logic outside of net/ (pidfd and seccomp), relocate and rename __scm_install_fd() from net/core/scm.c to __fd_install_received() in fs/file.c, and provide a wrapper named fd_install_received_user(), as future patches will change the interfac