Re: [PATCH v4 00/17] netdev: Eliminate duplicate barriers on weakly-ordered archs

2018-03-21 Thread Sinan Kaya
On 3/21/2018 10:56 AM, David Miller wrote: > From: Sinan Kaya > Date: Mon, 19 Mar 2018 22:42:15 -0400 > >> Code includes wmb() followed by writel() in multiple places. writel() >> already has a barrier on some architectures like arm64. >> >> This ends up CPU observing two barriers back to back be

Re: [PATCH v4 00/17] netdev: Eliminate duplicate barriers on weakly-ordered archs

2018-03-21 Thread David Miller
From: Sinan Kaya Date: Mon, 19 Mar 2018 22:42:15 -0400 > Code includes wmb() followed by writel() in multiple places. writel() > already has a barrier on some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing the > register write. > > Since code

[PATCH v4 00/17] netdev: Eliminate duplicate barriers on weakly-ordered archs

2018-03-19 Thread Sinan Kaya
Code includes wmb() followed by writel() in multiple places. writel() already has a barrier on some architectures like arm64. This ends up CPU observing two barriers back to back before executing the register write. Since code already has an explicit barrier call, changing writel() to writel_rela