Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-09 Thread Vivien Didelot
Hi David, - On Jul 9, 2015, at 2:01 PM, David da...@davemloft.net wrote: > From: Vivien Didelot > Date: Wed, 8 Jul 2015 13:13:16 -0400 (EDT) > >> You're right. There's a single operation to clear the STU and VTU. I >> will send a follow-up patch to send this command during the switch >> set

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-09 Thread David Miller
From: Vivien Didelot Date: Wed, 8 Jul 2015 13:13:16 -0400 (EDT) > You're right. There's a single operation to clear the STU and VTU. I > will send a follow-up patch to send this command during the switch > setup. Fix known bugs in the patch series, within the patch series, since it hasn't been m

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Vivien Didelot
Hi Andrew, - On Jul 8, 2015, at 4:12 PM, Andrew Lunn and...@lunn.ch wrote: >> I understand. However this whole VLAN thing represents a lot of code. >> Some other work depends on portions of it. Do you think it'd be OK if I >> resend the patch 1/3 alone? Having only the VTU operations and "vtu

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Andrew Lunn
> I understand. However this whole VLAN thing represents a lot of code. > Some other work depends on portions of it. Do you think it'd be OK if I > resend the patch 1/3 alone? Having only the VTU operations and "vtu" > debugfs file does not break the actual behavior, and will lighten up the > follo

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Andrew Lunn
> > This is a limitation of the switch. So the driver needs to keep track > > of which bridge a VLAN belongs to, if it is asked to accelerate the > > same VLAN for a different bridge, it needs to say to the kernel, > > sorry, cannot do that, and leave the kernel to do it in software. > > Scott, ho

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Vivien Didelot
Hi Andrew, On Jul 8, 2015, at 1:32 PM, Andrew Lunn and...@lunn.ch wrote: > Vivien Didelot wrote: >> Hi Andrew, >> >> On Jul 8, 2015, at 10:38 AM, Andrew Lunn and...@lunn.ch wrote: >> >> > On Tue, Jul 07, 2015 at 05:18:17PM -0400, Vivien Didelot wrote: >> >> Hi all, >> >> >> >> This patchset br

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Andrew Lunn
Vivien Didelot wrote: > Hi Andrew, > > On Jul 8, 2015, at 10:38 AM, Andrew Lunn and...@lunn.ch wrote: > > > On Tue, Jul 07, 2015 at 05:18:17PM -0400, Vivien Didelot wrote: > >> Hi all, > >> > >> This patchset brings full support for hardware VLANs in DSA, and the > >> Marvell > >> 88E6xxx compa

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Vivien Didelot
Hi Andrew, On Jul 8, 2015, at 10:38 AM, Andrew Lunn and...@lunn.ch wrote: > On Tue, Jul 07, 2015 at 05:18:17PM -0400, Vivien Didelot wrote: >> Hi all, >> >> This patchset brings full support for hardware VLANs in DSA, and the Marvell >> 88E6xxx compatible switch chips. > > Hi Vivien > > I woul

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-08 Thread Andrew Lunn
On Tue, Jul 07, 2015 at 05:18:17PM -0400, Vivien Didelot wrote: > Hi all, > > This patchset brings full support for hardware VLANs in DSA, and the Marvell > 88E6xxx compatible switch chips. Hi Vivien I would like to do a proper review and testing of these patchset, but i go on vacation this afte

[PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-07 Thread Vivien Didelot
Hi all, This patchset brings full support for hardware VLANs in DSA, and the Marvell 88E6xxx compatible switch chips. The first patch adds the VTU operations to the mv88e6xxx code, as well as a "vtu" debugfs file to read and modify the hardware VLAN table. The second patch adds the glue between