Re: [PATCH v4] staging: qlge: fix build breakage with dumping enabled

2020-10-04 Thread Benjamin Poirier
On 2020-10-04 23:22 +0800, Coiby Xu wrote: > On Sat, Oct 03, 2020 at 02:53:48PM +0900, Benjamin Poirier wrote: > > On 2020-10-03 07:59 +0800, Coiby Xu wrote: > > > This fixes commit 0107635e15ac > > > ("staging: qlge: replace pr_err with netdev_err") which introduced an > > > build breakage of miss

Re: [PATCH v4] staging: qlge: fix build breakage with dumping enabled

2020-10-04 Thread Coiby Xu
On Sat, Oct 03, 2020 at 02:53:48PM +0900, Benjamin Poirier wrote: On 2020-10-03 07:59 +0800, Coiby Xu wrote: This fixes commit 0107635e15ac ("staging: qlge: replace pr_err with netdev_err") which introduced an build breakage of missing `struct ql_adapter *qdev` for some functions and a warning o

Re: [PATCH v4] staging: qlge: fix build breakage with dumping enabled

2020-10-02 Thread Benjamin Poirier
On 2020-10-03 07:59 +0800, Coiby Xu wrote: > This fixes commit 0107635e15ac > ("staging: qlge: replace pr_err with netdev_err") which introduced an > build breakage of missing `struct ql_adapter *qdev` for some functions > and a warning of type mismatch with dumping enabled, i.e., > > $ make CFLAG

[PATCH v4] staging: qlge: fix build breakage with dumping enabled

2020-10-02 Thread Coiby Xu
This fixes commit 0107635e15ac ("staging: qlge: replace pr_err with netdev_err") which introduced an build breakage of missing `struct ql_adapter *qdev` for some functions and a warning of type mismatch with dumping enabled, i.e., $ make CFLAGS_MODULE="-DQL_ALL_DUMP -DQL_OB_DUMP -DQL_CB_DUMP \