Re: [PATCH v4] net: dsa: microchip: call phy_remove_link_mode during probe

2020-07-21 Thread David Miller
From: Helmut Grohne Date: Tue, 21 Jul 2020 13:07:39 +0200 > When doing "ip link set dev ... up" for a ksz9477 backed link, > ksz9477_phy_setup is called and it calls phy_remove_link_mode to remove > 1000baseT HDX. During phy_remove_link_mode, phy_advertise_supported is > called. Doing so reverts

Re: [PATCH v4] net: dsa: microchip: call phy_remove_link_mode during probe

2020-07-21 Thread Andrew Lunn
On Tue, Jul 21, 2020 at 01:07:39PM +0200, Helmut Grohne wrote: > When doing "ip link set dev ... up" for a ksz9477 backed link, > ksz9477_phy_setup is called and it calls phy_remove_link_mode to remove > 1000baseT HDX. During phy_remove_link_mode, phy_advertise_supported is > called. Doing so rever

[PATCH v4] net: dsa: microchip: call phy_remove_link_mode during probe

2020-07-21 Thread Helmut Grohne
When doing "ip link set dev ... up" for a ksz9477 backed link, ksz9477_phy_setup is called and it calls phy_remove_link_mode to remove 1000baseT HDX. During phy_remove_link_mode, phy_advertise_supported is called. Doing so reverts any previous change to advertised link modes e.g. using a udevd .lin