Re: [PATCH v4] net: dev_weight: TX/RX orthogonality

2016-12-29 Thread Matthias Tafelmeier
> Actually, reverted, you didn't even build test this: > > net/core/dev.c:3433:35: error: initializer element is not constant > int dev_rx_weight __read_mostly = weight_p; >^~~~ > net/core/dev.c:3434:35: error: initializer element is not constant > int dev

Re: [PATCH v4] net: dev_weight: TX/RX orthogonality

2016-12-29 Thread David Miller
Actually, reverted, you didn't even build test this: net/core/dev.c:3433:35: error: initializer element is not constant int dev_rx_weight __read_mostly = weight_p; ^~~~ net/core/dev.c:3434:35: error: initializer element is not constant int dev_tx_weight __

Re: [PATCH v4] net: dev_weight: TX/RX orthogonality

2016-12-29 Thread David Miller
From: Matthias Tafelmeier Date: Thu, 29 Dec 2016 20:23:18 +0100 > Oftenly, introducing side effects on packet processing on the other half > of the stack by adjusting one of TX/RX via sysctl is not desirable. > There are cases of demand for asymmetric, orthogonal configurability. > > This holds

[PATCH v4] net: dev_weight: TX/RX orthogonality

2016-12-29 Thread Matthias Tafelmeier
Oftenly, introducing side effects on packet processing on the other half of the stack by adjusting one of TX/RX via sysctl is not desirable. There are cases of demand for asymmetric, orthogonal configurability. This holds true especially for nodes where RPS for RFS usage on top is configured and t

Re: [PATCH v4] net: dev_weight: TX/RX orthogonality

2016-12-29 Thread David Miller
From: Matthias Tafelmeier Date: Thu, 29 Dec 2016 10:58:41 +0100 > Oftenly, introducing side effects on packet processing on the other half > of the stack by adjusting one of TX/RX via sysctl is not desirable. > There are cases of demand for asymmetric, orthogonal configurability. > > This holds

[PATCH v4] net: dev_weight: TX/RX orthogonality

2016-12-29 Thread Matthias Tafelmeier
Oftenly, introducing side effects on packet processing on the other half of the stack by adjusting one of TX/RX via sysctl is not desirable. There are cases of demand for asymmetric, orthogonal configurability. This holds true especially for nodes where RPS for RFS usage on top is configured and t