Re: [PATCH v4] leds: trigger: Introduce a NETDEV trigger

2017-12-10 Thread Jacek Anaszewski
On 12/10/2017 08:12 PM, Ben Whitten wrote: > Hi Jacek, > > On 10 December 2017 at 18:31, Jacek Anaszewski > wrote: >> Hi Ben, >> >> Thanks for the update. I have one doubt about comment style >> at the top of the file. Please refer below. >> >> On 12/10/2017 05:24 PM, Ben Whitten wrote: >>> This

Re: [PATCH v4] leds: trigger: Introduce a NETDEV trigger

2017-12-10 Thread Ben Whitten
Hi Jacek, On 10 December 2017 at 18:31, Jacek Anaszewski wrote: > Hi Ben, > > Thanks for the update. I have one doubt about comment style > at the top of the file. Please refer below. > > On 12/10/2017 05:24 PM, Ben Whitten wrote: >> This commit introduces a NETDEV trigger for named device >> act

Re: [PATCH v4] leds: trigger: Introduce a NETDEV trigger

2017-12-10 Thread Philippe Ombredanne
On Sun, Dec 10, 2017 at 5:24 PM, Ben Whitten wrote: > This commit introduces a NETDEV trigger for named device > activity. Available triggers are link, rx, and tx. > > Signed-off-by: Ben Whitten > > --- > Changes in v4: > Adopt SPDX licence header Thanks you! Acked-by: Philippe Ombredanne > Ch

Re: [PATCH v4] leds: trigger: Introduce a NETDEV trigger

2017-12-10 Thread Jacek Anaszewski
Hi Ben, Thanks for the update. I have one doubt about comment style at the top of the file. Please refer below. On 12/10/2017 05:24 PM, Ben Whitten wrote: > This commit introduces a NETDEV trigger for named device > activity. Available triggers are link, rx, and tx. > > Signed-off-by: Ben Whitte

[PATCH v4] leds: trigger: Introduce a NETDEV trigger

2017-12-10 Thread Ben Whitten
This commit introduces a NETDEV trigger for named device activity. Available triggers are link, rx, and tx. Signed-off-by: Ben Whitten --- Changes in v4: Adopt SPDX licence header Changes in v3: Cancel the software blink prior to a oneshot re-queue Changes in v2: Sort includes and redate documen