Re: [PATCH v4,net-next] vlan: implement vlan id and protocol changes

2018-07-07 Thread David Miller
From: David Ahern Date: Sat, 7 Jul 2018 19:23:16 -0600 > On 7/7/18 7:14 AM, Ido Schimmel wrote: >> On Sat, Jul 07, 2018 at 08:11:16PM +0900, David Miller wrote: >>> Chas, it seems to me that you add the new notifier by not even one >>> driver is listening for the event. >>> >>> Either it is neces

Re: [PATCH v4,net-next] vlan: implement vlan id and protocol changes

2018-07-07 Thread David Ahern
On 7/7/18 7:14 AM, Ido Schimmel wrote: > On Sat, Jul 07, 2018 at 08:11:16PM +0900, David Miller wrote: >> Chas, it seems to me that you add the new notifier by not even one >> driver is listening for the event. >> >> Either it is necessary, and you should show at least one example >> use case, or i

Re: [PATCH v4,net-next] vlan: implement vlan id and protocol changes

2018-07-07 Thread Ido Schimmel
On Sat, Jul 07, 2018 at 08:11:16PM +0900, David Miller wrote: > Chas, it seems to me that you add the new notifier by not even one > driver is listening for the event. > > Either it is necessary, and you should show at least one example > use case, or it not necessary and therefore should not be a

Re: [PATCH v4,net-next] vlan: implement vlan id and protocol changes

2018-07-07 Thread David Miller
From: Chas Williams <3ch...@gmail.com> Date: Mon, 2 Jul 2018 18:35:28 -0400 > vlan_changelink silently ignores attempts to change the vlan id > or protocol id of an existing vlan interface. Implement by adding > the new vlan id and protocol to the interface's vlan group and then > removing the o

[PATCH v4,net-next] vlan: implement vlan id and protocol changes

2018-07-02 Thread Chas Williams
vlan_changelink silently ignores attempts to change the vlan id or protocol id of an existing vlan interface. Implement by adding the new vlan id and protocol to the interface's vlan group and then removing the old vlan id and protocol from the vlan group. This avoids the netlink churn of deletin