Re: [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-25 Thread Pravin Shelar
On Tue, Aug 25, 2015 at 9:50 AM, Jesse Gross wrote: > On Mon, Aug 24, 2015 at 7:15 PM, Pravin Shelar wrote: >> On Mon, Aug 24, 2015 at 6:42 PM, Jesse Gross wrote: >>> On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar >>> wrote: diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c

Re: [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-25 Thread Thomas Graf
On 08/24/15 at 10:43am, Pravin B Shelar wrote: > + if (ip_tunnel_collect_metadata() && geneve->collect_md) { > + __be16 flags; > + void *opts; > + I think this should be || -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-25 Thread Thomas Graf
On 08/25/15 at 09:50am, Jesse Gross wrote: > On Mon, Aug 24, 2015 at 7:15 PM, Pravin Shelar wrote: > > Moving this device means moving all tunnels backed by this device > > rather than specific tunnel device. Thats why it does not look right > > to move such device. > > I agree it seems weird in

Re: [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-25 Thread Jesse Gross
On Mon, Aug 24, 2015 at 7:15 PM, Pravin Shelar wrote: > On Mon, Aug 24, 2015 at 6:42 PM, Jesse Gross wrote: >> On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar wrote: >>> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >>> index 0a6d974..c05bc13 100644 >>> --- a/drivers/net/geneve.c >>

Re: [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-24 Thread Pravin Shelar
On Mon, Aug 24, 2015 at 6:42 PM, Jesse Gross wrote: > On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar wrote: >> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >> index 0a6d974..c05bc13 100644 >> --- a/drivers/net/geneve.c >> +++ b/drivers/net/geneve.c >> @@ -141,10 +190,15 @@ drop: >>

Re: [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-24 Thread Jesse Gross
On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 0a6d974..c05bc13 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > @@ -141,10 +190,15 @@ drop: > /* Setup stats when device is created */ > static int gene

[PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-24 Thread Pravin B Shelar
Following patch create new tunnel flag which enable tunnel metadata collection on given device. These devices can be used by tunnel metadata based routing or by OVS. Geneve Consolidation patch get rid of collect_md_tun to simplify tunnel lookup further. Signed-off-by: Pravin B Shelar --- v2-v3: D