Re: [PATCH v3 net-next 5/5] net: dsa: lan9303: refactor lan9303_get_ethtool_stats

2017-08-03 Thread Egil Hjelmeland
Den 03. aug. 2017 20:04, skrev Florian Fainelli: On 08/03/2017 02:45 AM, Egil Hjelmeland wrote: In lan9303_get_ethtool_stats: Get rid of 0x400 constant magic by using new lan9303_read_switch_reg() inside loop. Reduced scope of two variables. Signed-off-by: Egil Hjelmeland --- drivers/net/dsa

Re: [PATCH v3 net-next 5/5] net: dsa: lan9303: refactor lan9303_get_ethtool_stats

2017-08-03 Thread Florian Fainelli
On 08/03/2017 02:45 AM, Egil Hjelmeland wrote: > In lan9303_get_ethtool_stats: Get rid of 0x400 constant magic > by using new lan9303_read_switch_reg() inside loop. > Reduced scope of two variables. > > Signed-off-by: Egil Hjelmeland > --- > drivers/net/dsa/lan9303-core.c | 26 --

Re: [PATCH v3 net-next 5/5] net: dsa: lan9303: refactor lan9303_get_ethtool_stats

2017-08-03 Thread Andrew Lunn
On Thu, Aug 03, 2017 at 11:45:07AM +0200, Egil Hjelmeland wrote: > In lan9303_get_ethtool_stats: Get rid of 0x400 constant magic > by using new lan9303_read_switch_reg() inside loop. > Reduced scope of two variables. > > Signed-off-by: Egil Hjelmeland Reviewed-by: Andrew Lunn Andrew

[PATCH v3 net-next 5/5] net: dsa: lan9303: refactor lan9303_get_ethtool_stats

2017-08-03 Thread Egil Hjelmeland
In lan9303_get_ethtool_stats: Get rid of 0x400 constant magic by using new lan9303_read_switch_reg() inside loop. Reduced scope of two variables. Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-)