Re: [PATCH v3 net-next 3/3] rds: Extend RDS API for IPv6 support

2018-07-13 Thread Santosh Shilimkar
On 7/13/2018 4:27 PM, David Miller wrote: From: Santosh Shilimkar Date: Fri, 13 Jul 2018 15:00:59 -0700 Ofcourse any application built using upstream header and using SO_RDS_TRANSPORT will break but since this particular option was added for special case(application wants to upfront select tra

Re: [PATCH v3 net-next 3/3] rds: Extend RDS API for IPv6 support

2018-07-13 Thread David Miller
From: Santosh Shilimkar Date: Fri, 13 Jul 2018 15:00:59 -0700 > Ofcourse any application built using upstream header and > using SO_RDS_TRANSPORT will break but since this particular > option was added for special case(application wants to > upfront select transport instead letting bind figure it

Re: [PATCH v3 net-next 3/3] rds: Extend RDS API for IPv6 support

2018-07-13 Thread Santosh Shilimkar
Hi Dave, On 7/13/2018 2:25 PM, David Miller wrote: From: Ka-Cheong Poon Date: Fri, 13 Jul 2018 04:02:59 -0700 @@ -52,7 +52,7 @@ #define RDS_RECVERR 5 #define RDS_CONG_MONITOR 6 #define RDS_GET_MR_FOR_DEST 7 -#define SO_RDS_TRANSPORT

Re: [PATCH v3 net-next 3/3] rds: Extend RDS API for IPv6 support

2018-07-13 Thread David Miller
From: Ka-Cheong Poon Date: Fri, 13 Jul 2018 04:02:59 -0700 > @@ -52,7 +52,7 @@ > #define RDS_RECVERR 5 > #define RDS_CONG_MONITOR 6 > #define RDS_GET_MR_FOR_DEST 7 > -#define SO_RDS_TRANSPORT 8 > +#define SO_RDS_TRANSPORT 9 There i

Re: [PATCH v3 net-next 3/3] rds: Extend RDS API for IPv6 support

2018-07-13 Thread 吉藤英明
Hi, 2018-07-13 20:02 GMT+09:00 Ka-Cheong Poon : > There are many data structures (RDS socket options) used by RDS apps > which use a 32 bit integer to store IP address. To support IPv6, > struct in6_addr needs to be used. To ensure backward compatibility, a > new data structure is introduced for e

[PATCH v3 net-next 3/3] rds: Extend RDS API for IPv6 support

2018-07-13 Thread Ka-Cheong Poon
There are many data structures (RDS socket options) used by RDS apps which use a 32 bit integer to store IP address. To support IPv6, struct in6_addr needs to be used. To ensure backward compatibility, a new data structure is introduced for each of those data structures which use a 32 bit integer t