Re: [PATCH v3 net-next 2/6] drivers: net: xgene-v2: Add mac configuration

2017-03-07 Thread David Miller
From: Iyappan Subramanian Date: Fri, 3 Mar 2017 17:09:28 -0800 > +void xge_mac_set_station_addr(struct xge_pdata *pdata) > +{ > + u32 addr0, addr1; > + u8 *dev_addr = pdata->ndev->dev_addr; Please order local variable declarations from longest to shortest line.

[PATCH v3 net-next 2/6] drivers: net: xgene-v2: Add mac configuration

2017-03-03 Thread Iyappan Subramanian
This patch adds functions to configure and control mac. This patch also adds helper functions to get/set registers. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- drivers/net/ethernet/apm/xgene-v2/mac.c | 116 drivers/net/ethernet/apm/xgene