Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-15 Thread Jakub Kicinski
On Mon, 14 Sep 2020 18:14:22 -0700 Shannon Nelson wrote: > So now we're beginning to dance around timeout boundaries - how can we > define the beginning and end of a timeout boundary, and how do they > relate to the component and label?  Currently, if either the component > or status_msg changes

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-15 Thread Jakub Kicinski
On Tue, 15 Sep 2020 15:11:06 -0700 Shannon Nelson wrote: > On 9/15/20 12:00 PM, Jakub Kicinski wrote: > > On Tue, 15 Sep 2020 11:44:07 -0700 Jacob Keller wrote: > >> Exactly how I saw it. > >> > >> Basically, the timeout should take effect as long as the (component, > >> msg) pair stays the same.

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-15 Thread Shannon Nelson
On 9/15/20 12:00 PM, Jakub Kicinski wrote: On Tue, 15 Sep 2020 11:44:07 -0700 Jacob Keller wrote: Exactly how I saw it. Basically, the timeout should take effect as long as the (component, msg) pair stays the same. So if you send percentage reports with the same message and component, then the

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-15 Thread Jakub Kicinski
On Tue, 15 Sep 2020 11:44:07 -0700 Jacob Keller wrote: > Exactly how I saw it. > > Basically, the timeout should take effect as long as the (component, > msg) pair stays the same. > > So if you send percentage reports with the same message and component, > then the timeout stays in effect. Once y

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-15 Thread Jacob Keller
On 9/15/2020 10:39 AM, Jakub Kicinski wrote: > On Tue, 15 Sep 2020 10:20:11 -0700 Shannon Nelson wrote: > What should the userland program do when the timeout expires?  Start > counting backwards?  Stop waiting?  Do we care to define this at the > moment? [component] bla bla

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-15 Thread Jakub Kicinski
On Tue, 15 Sep 2020 10:20:11 -0700 Shannon Nelson wrote: > >>> What should the userland program do when the timeout expires?  Start > >>> counting backwards?  Stop waiting?  Do we care to define this at the > >>> moment? > >> [component] bla bla X% (timeout reached) > > > > Yep. I don't think

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-15 Thread Shannon Nelson
On 9/15/20 9:50 AM, Keller, Jacob E wrote: -Original Message- From: Jakub Kicinski Sent: Tuesday, September 15, 2020 8:51 AM To: Shannon Nelson Cc: Keller, Jacob E ; netdev@vger.kernel.org; da...@davemloft.net Subject: Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

RE: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-15 Thread Keller, Jacob E
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, September 15, 2020 8:51 AM > To: Shannon Nelson > Cc: Keller, Jacob E ; netdev@vger.kernel.org; > da...@davemloft.net > Subject: Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update > > O

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-14 Thread Shannon Nelson
On 9/14/20 5:53 PM, Keller, Jacob E wrote: -Original Message- From: Shannon Nelson Sent: Monday, September 14, 2020 4:47 PM To: Jakub Kicinski ; Keller, Jacob E Cc: netdev@vger.kernel.org; da...@davemloft.net Subject: Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update On

RE: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-14 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Jakub Kicinski > Sent: Monday, September 14, 2020 4:36 PM > To: Keller, Jacob E > Cc: Shannon Nelson ; netdev@vger.kernel.org; > da...@davemloft.net > Subject: Re: [PATCH v3 net-next

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-14 Thread Shannon Nelson
On 9/14/20 4:36 PM, Jakub Kicinski wrote: On Mon, 14 Sep 2020 16:15:28 -0700 Jacob Keller wrote: On 9/10/2020 10:56 AM, Jakub Kicinski wrote: IOW drop the component parameter from the normal helper, cause almost nobody uses that. The add a more full featured __ version, which would take the arg

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-14 Thread Jakub Kicinski
On Mon, 14 Sep 2020 16:15:28 -0700 Jacob Keller wrote: > On 9/10/2020 10:56 AM, Jakub Kicinski wrote: > > IOW drop the component parameter from the normal helper, cause almost > > nobody uses that. The add a more full featured __ version, which would > > take the arg struct, the struct would includ

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-14 Thread Jacob Keller
On 9/10/2020 10:56 AM, Jakub Kicinski wrote: > On Wed, 9 Sep 2020 18:34:57 -0700 Shannon Nelson wrote: >> On 9/9/20 12:22 PM, Jakub Kicinski wrote: >>> On Wed, 9 Sep 2020 10:58:19 -0700 Shannon Nelson wrote: I'm suggesting that this implementation using the existing devlink logg

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-14 Thread Jacob Keller
On 9/10/2020 10:56 AM, Jakub Kicinski wrote: > IOW drop the component parameter from the normal helper, cause almost > nobody uses that. The add a more full featured __ version, which would > take the arg struct, the struct would include the timeout value. > I would point out that the ice drive

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-14 Thread Jakub Kicinski
On Mon, 14 Sep 2020 15:02:18 -0700 Shannon Nelson wrote: > On 9/10/20 10:56 AM, Jakub Kicinski wrote: > > On Wed, 9 Sep 2020 18:34:57 -0700 Shannon Nelson wrote: > >> On 9/9/20 12:22 PM, Jakub Kicinski wrote: > >>> On Wed, 9 Sep 2020 10:58:19 -0700 Shannon Nelson wrote: > I'm suggesting

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-14 Thread Shannon Nelson
On 9/10/20 10:56 AM, Jakub Kicinski wrote: On Wed, 9 Sep 2020 18:34:57 -0700 Shannon Nelson wrote: On 9/9/20 12:22 PM, Jakub Kicinski wrote: On Wed, 9 Sep 2020 10:58:19 -0700 Shannon Nelson wrote: I'm suggesting that this implementation using the existing devlink logging services should suffic

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-10 Thread Jakub Kicinski
On Wed, 9 Sep 2020 18:34:57 -0700 Shannon Nelson wrote: > On 9/9/20 12:22 PM, Jakub Kicinski wrote: > > On Wed, 9 Sep 2020 10:58:19 -0700 Shannon Nelson wrote: > >> > >> I'm suggesting that this implementation using the existing devlink > >> logging services should suffice until someone can desig

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-09 Thread Shannon Nelson
On 9/9/20 12:22 PM, Jakub Kicinski wrote: On Wed, 9 Sep 2020 10:58:19 -0700 Shannon Nelson wrote: I'm suggesting that this implementation using the existing devlink logging services should suffice until someone can design, implement, and get accepted a different bit of plumbing.  Unfortunately,

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-09 Thread David Miller
From: Shannon Nelson Date: Wed, 9 Sep 2020 10:58:19 -0700 > I'm suggesting that this implementation using the existing devlink > logging services should suffice until someone can design, implement, > and get accepted a different bit of plumbing.  Unfortunately, that's > not a job that I can get t

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-09 Thread Jakub Kicinski
On Wed, 9 Sep 2020 10:58:19 -0700 Shannon Nelson wrote: > On 9/9/20 9:44 AM, Jakub Kicinski wrote: > > On Wed, 9 Sep 2020 09:23:08 -0700 Shannon Nelson wrote: > >> On 9/8/20 4:54 PM, Jakub Kicinski wrote: > >>> On Tue, 8 Sep 2020 15:48:12 -0700 Shannon Nelson wrote: > +dl = priv

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-09 Thread Shannon Nelson
On 9/9/20 9:44 AM, Jakub Kicinski wrote: On Wed, 9 Sep 2020 09:23:08 -0700 Shannon Nelson wrote: On 9/8/20 4:54 PM, Jakub Kicinski wrote: On Tue, 8 Sep 2020 15:48:12 -0700 Shannon Nelson wrote: + dl = priv_to_devlink(ionic); + devlink_flash_update_status_notify(dl, label, NULL, 1,

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-09 Thread Jakub Kicinski
On Wed, 9 Sep 2020 09:23:08 -0700 Shannon Nelson wrote: > On 9/8/20 4:54 PM, Jakub Kicinski wrote: > > On Tue, 8 Sep 2020 15:48:12 -0700 Shannon Nelson wrote: > >> + dl = priv_to_devlink(ionic); > >> + devlink_flash_update_status_notify(dl, label, NULL, 1, timeout); > >> + start_time = jiffie

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-09 Thread Shannon Nelson
On 9/8/20 4:54 PM, Jakub Kicinski wrote: On Tue, 8 Sep 2020 15:48:12 -0700 Shannon Nelson wrote: + dl = priv_to_devlink(ionic); + devlink_flash_update_status_notify(dl, label, NULL, 1, timeout); + start_time = jiffies; + end_time = start_time + (timeout * HZ); + do

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-08 Thread Jakub Kicinski
On Tue, 8 Sep 2020 15:48:12 -0700 Shannon Nelson wrote: > + dl = priv_to_devlink(ionic); > + devlink_flash_update_status_notify(dl, label, NULL, 1, timeout); > + start_time = jiffies; > + end_time = start_time + (timeout * HZ); > + do { > + mutex_lock(&ionic->dev_cm

[PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-08 Thread Shannon Nelson
Add support for firmware update through the devlink interface. This update copies the firmware object into the device, asks the current firmware to install it, then asks the firmware to select the new firmware for the next boot-up. The install and select steps are launched as asynchronous requests