On 7/19/19 12:07 PM, Andrew Lunn wrote:
On Fri, Jul 19, 2019 at 11:41:28AM -0700, Shannon Nelson wrote:
On 7/18/19 7:40 PM, Andrew Lunn wrote:
On Thu, Jul 18, 2019 at 05:12:07PM -0700, Shannon Nelson wrote:
On 7/17/19 8:28 PM, Andrew Lunn wrote:
On Fri, Jul 12, 2019 at 10:16:31PM -0700, Shann
On Fri, Jul 19, 2019 at 11:41:28AM -0700, Shannon Nelson wrote:
> On 7/18/19 7:40 PM, Andrew Lunn wrote:
> >On Thu, Jul 18, 2019 at 05:12:07PM -0700, Shannon Nelson wrote:
> >>On 7/17/19 8:28 PM, Andrew Lunn wrote:
> >>>On Fri, Jul 12, 2019 at 10:16:31PM -0700, Shannon Nelson wrote:
> On 7/8/19
On 7/18/19 7:40 PM, Andrew Lunn wrote:
On Thu, Jul 18, 2019 at 05:12:07PM -0700, Shannon Nelson wrote:
On 7/17/19 8:28 PM, Andrew Lunn wrote:
On Fri, Jul 12, 2019 at 10:16:31PM -0700, Shannon Nelson wrote:
On 7/8/19 7:14 PM, Andrew Lunn wrote:
+static int ionic_set_pauseparam(struct net_devic
On Thu, Jul 18, 2019 at 05:12:07PM -0700, Shannon Nelson wrote:
> On 7/17/19 8:28 PM, Andrew Lunn wrote:
> >On Fri, Jul 12, 2019 at 10:16:31PM -0700, Shannon Nelson wrote:
> >>On 7/8/19 7:14 PM, Andrew Lunn wrote:
> +static int ionic_set_pauseparam(struct net_device *netdev,
> +
On 7/17/19 8:28 PM, Andrew Lunn wrote:
On Fri, Jul 12, 2019 at 10:16:31PM -0700, Shannon Nelson wrote:
On 7/8/19 7:14 PM, Andrew Lunn wrote:
+static int ionic_set_pauseparam(struct net_device *netdev,
+ struct ethtool_pauseparam *pause)
+{
+ struct lif *lif =
On 7/18/19 10:28 AM, Andrew Lunn wrote:
On Thu, Jul 18, 2019 at 10:05:23AM -0700, Shannon Nelson wrote:
On 7/17/19 8:21 PM, Andrew Lunn wrote:
On Tue, Jul 09, 2019 at 03:42:39PM -0700, Shannon Nelson wrote:
On 7/8/19 7:27 PM, Andrew Lunn wrote:
+static int ionic_get_module_eeprom(struct net_d
On Thu, Jul 18, 2019 at 10:05:23AM -0700, Shannon Nelson wrote:
> On 7/17/19 8:21 PM, Andrew Lunn wrote:
> >On Tue, Jul 09, 2019 at 03:42:39PM -0700, Shannon Nelson wrote:
> >>On 7/8/19 7:27 PM, Andrew Lunn wrote:
> +static int ionic_get_module_eeprom(struct net_device *netdev,
> +
On 7/17/19 8:31 PM, Andrew Lunn wrote:
On Fri, Jul 12, 2019 at 10:32:38PM -0700, Shannon Nelson wrote:
On 7/8/19 7:30 PM, Andrew Lunn wrote:
+static int ionic_nway_reset(struct net_device *netdev)
+{
+ struct lif *lif = netdev_priv(netdev);
+ int err = 0;
+
+ if (netif_running
On 7/17/19 8:21 PM, Andrew Lunn wrote:
On Tue, Jul 09, 2019 at 03:42:39PM -0700, Shannon Nelson wrote:
On 7/8/19 7:27 PM, Andrew Lunn wrote:
+static int ionic_get_module_eeprom(struct net_device *netdev,
+ struct ethtool_eeprom *ee,
+
On Fri, Jul 12, 2019 at 10:32:38PM -0700, Shannon Nelson wrote:
> On 7/8/19 7:30 PM, Andrew Lunn wrote:
> >>+static int ionic_nway_reset(struct net_device *netdev)
> >>+{
> >>+ struct lif *lif = netdev_priv(netdev);
> >>+ int err = 0;
> >>+
> >>+ if (netif_running(netdev))
> >>+ err
On Fri, Jul 12, 2019 at 10:16:31PM -0700, Shannon Nelson wrote:
> On 7/8/19 7:14 PM, Andrew Lunn wrote:
> >>+static int ionic_set_pauseparam(struct net_device *netdev,
> >>+ struct ethtool_pauseparam *pause)
> >>+{
> >>+ struct lif *lif = netdev_priv(netdev);
> >>+ str
On Tue, Jul 09, 2019 at 03:42:39PM -0700, Shannon Nelson wrote:
> On 7/8/19 7:27 PM, Andrew Lunn wrote:
> >>+static int ionic_get_module_eeprom(struct net_device *netdev,
> >>+ struct ethtool_eeprom *ee,
> >>+ u8 *data)
> >>+{
> >>+ struct
On 7/8/19 7:30 PM, Andrew Lunn wrote:
+static int ionic_nway_reset(struct net_device *netdev)
+{
+ struct lif *lif = netdev_priv(netdev);
+ int err = 0;
+
+ if (netif_running(netdev))
+ err = ionic_reset_queues(lif);
What does ionic_reset_queues() do? It sounds no
On 7/8/19 7:14 PM, Andrew Lunn wrote:
+static int ionic_set_pauseparam(struct net_device *netdev,
+ struct ethtool_pauseparam *pause)
+{
+ struct lif *lif = netdev_priv(netdev);
+ struct ionic *ionic = lif->ionic;
+ struct ionic_dev *idev = &lif->io
On 7/8/19 3:04 PM, Andrew Lunn wrote:
+ case XCVR_PID_SFP_10GBASE_ER:
+ ethtool_link_ksettings_add_link_mode(ks, supported,
+1baseER_Full);
+ break;
I don't know these link modes too well. But only setting
On 7/8/19 7:27 PM, Andrew Lunn wrote:
+static int ionic_get_module_eeprom(struct net_device *netdev,
+ struct ethtool_eeprom *ee,
+ u8 *data)
+{
+ struct lif *lif = netdev_priv(netdev);
+ struct ionic_dev *idev = &lif->
On 7/8/19 10:15 PM, Michal Kubecek wrote:
Also, there is no need to zero initialize ks->link_modes.advertising
above if it's going to be rewritten here anyway.
Michal
Got it.
Thanks,
sln
On 7/8/19 10:25 PM, Michal Kubecek wrote:
On Mon, Jul 08, 2019 at 12:25:26PM -0700, Shannon Nelson wrote:
Add in the basic ethtool callbacks for device information
and control.
+
+ if (fec_type != idev->port_info->config.fec_type) {
+ mutex_lock(&ionic->dev_cmd_lock);
+
On Mon, Jul 08, 2019 at 12:25:26PM -0700, Shannon Nelson wrote:
> Add in the basic ethtool callbacks for device information
> and control.
>
> Signed-off-by: Shannon Nelson
> ---
> drivers/net/ethernet/pensando/ionic/Makefile | 2 +-
> .../net/ethernet/pensando/ionic/ionic_dev.h | 3 +
>
On Tue, Jul 09, 2019 at 12:04:06AM +0200, Andrew Lunn wrote:
> > +static int ionic_get_link_ksettings(struct net_device *netdev,
> > + struct ethtool_link_ksettings *ks)
> > +{
> > + struct lif *lif = netdev_priv(netdev);
> > + struct ionic_dev *idev = &lif->ionic-
> +static int ionic_nway_reset(struct net_device *netdev)
> +{
> + struct lif *lif = netdev_priv(netdev);
> + int err = 0;
> +
> + if (netif_running(netdev))
> + err = ionic_reset_queues(lif);
What does ionic_reset_queues() do? It sounds nothing like restarting
auto negotia
> +static int ionic_get_module_eeprom(struct net_device *netdev,
> +struct ethtool_eeprom *ee,
> +u8 *data)
> +{
> + struct lif *lif = netdev_priv(netdev);
> + struct ionic_dev *idev = &lif->ionic->idev;
> + struct xcvr_sta
> +static int ionic_set_pauseparam(struct net_device *netdev,
> + struct ethtool_pauseparam *pause)
> +{
> + struct lif *lif = netdev_priv(netdev);
> + struct ionic *ionic = lif->ionic;
> + struct ionic_dev *idev = &lif->ionic->idev;
> +
> + u32 requested
> +static int ionic_get_link_ksettings(struct net_device *netdev,
> + struct ethtool_link_ksettings *ks)
> +{
> + struct lif *lif = netdev_priv(netdev);
> + struct ionic_dev *idev = &lif->ionic->idev;
> + int copper_seen = 0;
> +
> + ethtool_link_kset
Add in the basic ethtool callbacks for device information
and control.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/Makefile | 2 +-
.../net/ethernet/pensando/ionic/ionic_dev.h | 3 +
.../ethernet/pensando/ionic/ionic_ethtool.c | 509 ++
.../ethe
25 matches
Mail list logo
