Re: [PATCH v3 net-next 08/21] nvme-tcp : Recalculate crc in the end of the capsule

2021-02-07 Thread Or Gerlitz
On Wed, Feb 3, 2021 at 11:12 AM Sagi Grimberg wrote: > On 2/1/21 2:04 AM, Boris Pismenny wrote: > > @@ -290,12 +341,9 @@ int nvme_tcp_setup_ddp(struct nvme_tcp_queue *queue, > > } > > > > req->ddp.command_id = command_id; > > - req->ddp.sg_table.sgl = req->ddp.first_sgl; > > -

Re: [PATCH v3 net-next 08/21] nvme-tcp : Recalculate crc in the end of the capsule

2021-02-04 Thread Or Gerlitz
On Wed, Feb 3, 2021 at 11:12 AM Sagi Grimberg wrote: > > @@ -1841,8 +1913,10 @@ static void __nvme_tcp_stop_queue(struct > > nvme_tcp_queue *queue) > > nvme_tcp_restore_sock_calls(queue); > > cancel_work_sync(&queue->io_work); > > > > - if (test_bit(NVME_TCP_Q_OFF_DDP, &queue->fl

Re: [PATCH v3 net-next 08/21] nvme-tcp : Recalculate crc in the end of the capsule

2021-02-03 Thread Sagi Grimberg
On 2/1/21 2:04 AM, Boris Pismenny wrote: From: Ben Ben-ishay crc offload of the nvme capsule. Check if all the skb bits are on, and if not recalculate the crc in SW and check it. This patch reworks the receive-side crc calculation to always run at the end, so as to keep a single flow for bo

[PATCH v3 net-next 08/21] nvme-tcp : Recalculate crc in the end of the capsule

2021-02-01 Thread Boris Pismenny
From: Ben Ben-ishay crc offload of the nvme capsule. Check if all the skb bits are on, and if not recalculate the crc in SW and check it. This patch reworks the receive-side crc calculation to always run at the end, so as to keep a single flow for both offload and non-offload. This change simpli