Re: Renaming interfaces that are up (Was "Re: [PATCH v3 net-next 08/10] net: mscc: ocelot: register devlink") ports

2021-01-15 Thread Vladimir Oltean
On Fri, Jan 15, 2021 at 07:11:42PM +0200, Vladimir Oltean wrote: > By the way I removed the if condition and added nothing in its place, > just to see what would happen. I see a lot of these messages, I did not > investigate where they are coming from and why they are emitted. They go > away when I

Renaming interfaces that are up (Was "Re: [PATCH v3 net-next 08/10] net: mscc: ocelot: register devlink") ports

2021-01-15 Thread Vladimir Oltean
On Thu, Jan 14, 2021 at 08:44:35AM -0800, Jakub Kicinski wrote: > > > Can you unbind and bind the driver back and see if phys_port_name > > > always gets the correct value? (replay/udevadm test is not sufficient) > > > > Yes, and that udev renaming test failed miserably still. > > > > I have dhcpcd

Re: [PATCH v3 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-14 Thread Jakub Kicinski
On Thu, 14 Jan 2021 12:34:05 +0200 Vladimir Oltean wrote: > On Mon, Jan 11, 2021 at 11:19:09AM -0800, Jakub Kicinski wrote: > > > > devlink_port_attrs_set() should be called before netdev is registered, > > > > and devlink_port_type_eth_set() after. So this sequence makes me a tad > > > > suspiciou

Re: [PATCH v3 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-14 Thread Vladimir Oltean
On Mon, Jan 11, 2021 at 11:19:09AM -0800, Jakub Kicinski wrote: > > > devlink_port_attrs_set() should be called before netdev is registered, > > > and devlink_port_type_eth_set() after. So this sequence makes me a tad > > > suspicious. > > > > > > In particular IIRC devlink's .ndo_get_phys_port_nam

Re: [PATCH v3 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-11 Thread Jakub Kicinski
On Mon, 11 Jan 2021 19:13:44 +0200 Vladimir Oltean wrote: > On Sat, Jan 09, 2021 at 05:44:39PM -0800, Jakub Kicinski wrote: > > On Fri, 8 Jan 2021 19:59:48 +0200 Vladimir Oltean wrote: > > > From: Vladimir Oltean > > > > > > Add devlink integration into the mscc_ocelot switchdev driver. Only t

Re: [PATCH v3 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-11 Thread Vladimir Oltean
On Sat, Jan 09, 2021 at 05:44:39PM -0800, Jakub Kicinski wrote: > On Fri, 8 Jan 2021 19:59:48 +0200 Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > Add devlink integration into the mscc_ocelot switchdev driver. Only the > > probed interfaces are registered with devlink, because for conv

Re: [PATCH v3 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-09 Thread Jakub Kicinski
On Fri, 8 Jan 2021 19:59:48 +0200 Vladimir Oltean wrote: > From: Vladimir Oltean > > Add devlink integration into the mscc_ocelot switchdev driver. Only the > probed interfaces are registered with devlink, because for convenience, > struct devlink_port was included into struct ocelot_port_privat

Re: [PATCH v3 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-09 Thread Jakub Kicinski
On Fri, 8 Jan 2021 19:59:48 +0200 Vladimir Oltean wrote: > From: Vladimir Oltean > > Add devlink integration into the mscc_ocelot switchdev driver. Only the > probed interfaces are registered with devlink, because for convenience, > struct devlink_port was included into struct ocelot_port_privat

Re: [PATCH v3 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-08 Thread Florian Fainelli
On 1/8/2021 9:59 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Add devlink integration into the mscc_ocelot switchdev driver. Only the > probed interfaces are registered with devlink, because for convenience, > struct devlink_port was included into struct ocelot_port_private, which >

[PATCH v3 net-next 08/10] net: mscc: ocelot: register devlink ports

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean Add devlink integration into the mscc_ocelot switchdev driver. Only the probed interfaces are registered with devlink, because for convenience, struct devlink_port was included into struct ocelot_port_private, which is only initialized for the ports that are used. Since we