Re: [PATCH v3 net-next 04/10] net: dsa: felix: reindent struct dsa_switch_ops

2021-01-11 Thread Jakub Kicinski
On Mon, 11 Jan 2021 19:01:58 +0200 Vladimir Oltean wrote: > On Sat, Jan 09, 2021 at 05:24:19PM -0800, Jakub Kicinski wrote: > > On Fri, 8 Jan 2021 19:59:44 +0200 Vladimir Oltean wrote: > > > From: Vladimir Oltean > > > > > > The devlink function pointer names are super long, and they would brea

Re: [PATCH v3 net-next 04/10] net: dsa: felix: reindent struct dsa_switch_ops

2021-01-11 Thread Vladimir Oltean
On Sat, Jan 09, 2021 at 05:24:19PM -0800, Jakub Kicinski wrote: > On Fri, 8 Jan 2021 19:59:44 +0200 Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > The devlink function pointer names are super long, and they would break > > the alignment. So reindent the existing ops now by adding one ta

Re: [PATCH v3 net-next 04/10] net: dsa: felix: reindent struct dsa_switch_ops

2021-01-09 Thread Jakub Kicinski
On Fri, 8 Jan 2021 19:59:44 +0200 Vladimir Oltean wrote: > From: Vladimir Oltean > > The devlink function pointer names are super long, and they would break > the alignment. So reindent the existing ops now by adding one tab. Therefore it'd be tempting to prefix them with dl_ rather than full d

Re: [PATCH v3 net-next 04/10] net: dsa: felix: reindent struct dsa_switch_ops

2021-01-08 Thread Florian Fainelli
On 1/8/2021 9:59 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > The devlink function pointer names are super long, and they would break > the alignment. So reindent the existing ops now by adding one tab. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

[PATCH v3 net-next 04/10] net: dsa: felix: reindent struct dsa_switch_ops

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean The devlink function pointer names are super long, and they would break the alignment. So reindent the existing ops now by adding one tab. Signed-off-by: Vladimir Oltean --- Changes in v3: None. Changes in v2: None. drivers/net/dsa/ocelot/felix.c | 78 +-