Re: [PATCH v3 net-next 03/11] sfc_ef100: read Design Parameters at probe time

2020-08-10 Thread Guenter Roeck
On Mon, Aug 10, 2020 at 09:15:20AM +0100, Edward Cree wrote: > On 09/08/2020 01:29, Guenter Roeck wrote: > > On Mon, Aug 03, 2020 at 09:33:20PM +0100, Edward Cree wrote: > >> + if (EFX_MIN_DMAQ_SIZE % reader->value) { > > This is a 64-bit operation (value is 64 bit). Result on 32-bit build

Re: [PATCH v3 net-next 03/11] sfc_ef100: read Design Parameters at probe time

2020-08-10 Thread Edward Cree
On 09/08/2020 01:29, Guenter Roeck wrote: > On Mon, Aug 03, 2020 at 09:33:20PM +0100, Edward Cree wrote: >> +if (EFX_MIN_DMAQ_SIZE % reader->value) { > This is a 64-bit operation (value is 64 bit). Result on 32-bit builds: > > ERROR: modpost: "__umoddi3" [drivers/net/ethernet/sfc/sfc.ko

Re: [PATCH v3 net-next 03/11] sfc_ef100: read Design Parameters at probe time

2020-08-08 Thread Guenter Roeck
On Mon, Aug 03, 2020 at 09:33:20PM +0100, Edward Cree wrote: > Several parts of the EF100 architecture are parameterised (to allow > varying capabilities on FPGAs according to resource constraints), and > these parameters are exposed to the driver through a TLV-encoded > region of the BAR. > For

[PATCH v3 net-next 03/11] sfc_ef100: read Design Parameters at probe time

2020-08-03 Thread Edward Cree
Several parts of the EF100 architecture are parameterised (to allow varying capabilities on FPGAs according to resource constraints), and these parameters are exposed to the driver through a TLV-encoded region of the BAR. For the most part we either don't care about these values at all or just