Re: [PATCH v3 net] rxrpc: fix race condition in rxrpc_input_packet()

2019-04-24 Thread Eric Dumazet
On 04/24/2019 01:27 AM, David Howells wrote: > > Acked-by: David Howells > A v4 is coming, since @local could be NULL in rxrpc_lookup_local() as reported by kbuild test robot and Julia Lawall diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c index 15cf42d5b53a56d8d19cab

Re: [PATCH v3 net] rxrpc: fix race condition in rxrpc_input_packet()

2019-04-24 Thread David Howells
Eric Dumazet wrote: > After commit 5271953cad31 ("rxrpc: Use the UDP encap_rcv hook"), > rxrpc_input_packet() is directly called from lockless UDP receive > path, under rcu_read_lock() protection. > > It must therefore use RCU rules : > > - udp_sk->sk_user_data can be cleared at any point in th

[PATCH v3 net] rxrpc: fix race condition in rxrpc_input_packet()

2019-04-23 Thread Eric Dumazet
After commit 5271953cad31 ("rxrpc: Use the UDP encap_rcv hook"), rxrpc_input_packet() is directly called from lockless UDP receive path, under rcu_read_lock() protection. It must therefore use RCU rules : - udp_sk->sk_user_data can be cleared at any point in this function. rcu_dereference_sk_us