RE: [PATCH v3 for-next 05/13] IB/cm: Reference count ib_cm_ids

2015-05-21 Thread Hefty, Sean
> It remains to clean up ib_cm's ib_cm_listen interface now that > compare_data isn't used, but I'm not sure this belongs in this series. This patch series is changing the behavior that the compare data solves. Currently, the ib_cm handles all of the multiplexing for the rdma_cm -- that's the r

Re: [PATCH v3 for-next 05/13] IB/cm: Reference count ib_cm_ids

2015-05-20 Thread Haggai Eran
On 20/05/2015 03:49, Hefty, Sean wrote: >>> I wonder if the existing ib_cm interface is even what we want. >>> Currently, the rdma_cm pushes the private data (i.e. IP address) >>> comparison into the ib_cm. This is only used by the rdma_cm. >>> Should that instead be moved out of the ib_cm and han

RE: [PATCH v3 for-next 05/13] IB/cm: Reference count ib_cm_ids

2015-05-19 Thread Hefty, Sean
> I find Haggai's argument compelling, it is a very small amount of code > and data to add a sharing count, and a very large amount to duplicate > the whole service id map into cma.c. I get wanting to share the listen list, but we end up with this: > drivers/infiniband/core/cm.c