Re: [PATCH v3 bpf-next 2/3] bpf: implement CAP_BPF

2019-09-06 Thread kbuild test robot
Hi Alexei, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Alexei-Starovoitov/capability-introduce-CAP_BPF-and-CAP_TRACING/20190906-215814 base: https://kernel.googlesource.com/pub/scm/linux/kernel

Re: [PATCH v3 bpf-next 2/3] bpf: implement CAP_BPF

2019-09-06 Thread Alexei Starovoitov
On Fri, Sep 6, 2019 at 9:21 AM kbuild test robot wrote: > > Hi Alexei, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on bpf-next/master] > > url: > https://github.com/0day-ci/linux/commits/Alexei-Starovoitov/capability-introduce-CAP_BPF-and-CAP_TRACING/20190

Re: [PATCH v3 bpf-next 2/3] bpf: implement CAP_BPF

2019-09-06 Thread kbuild test robot
Hi Alexei, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Alexei-Starovoitov/capability-introduce-CAP_BPF-and-CAP_TRACING/20190906-215814 base: https://kernel.googlesource.com/pub/scm/linux/kernel

Re: [PATCH v3 bpf-next 2/3] bpf: implement CAP_BPF

2019-09-05 Thread Song Liu
> On Sep 4, 2019, at 8:15 PM, Alexei Starovoitov > wrote: > > On Thu, Sep 05, 2019 at 02:51:51AM +, Song Liu wrote: >> >> >>> On Sep 4, 2019, at 6:32 PM, Alexei Starovoitov >>> wrote: >>> >>> On Thu, Sep 05, 2019 at 12:34:36AM +, Song Liu wrote: > On Sep 4, 2019,

Re: [PATCH v3 bpf-next 2/3] bpf: implement CAP_BPF

2019-09-04 Thread Alexei Starovoitov
On Thu, Sep 05, 2019 at 02:51:51AM +, Song Liu wrote: > > > > On Sep 4, 2019, at 6:32 PM, Alexei Starovoitov > > wrote: > > > > On Thu, Sep 05, 2019 at 12:34:36AM +, Song Liu wrote: > >> > >> > >>> On Sep 4, 2019, at 11:43 AM, Alexei Starovoitov wrote: > >>> > >>> Implement permiss

Re: [PATCH v3 bpf-next 2/3] bpf: implement CAP_BPF

2019-09-04 Thread Song Liu
> On Sep 4, 2019, at 6:32 PM, Alexei Starovoitov > wrote: > > On Thu, Sep 05, 2019 at 12:34:36AM +, Song Liu wrote: >> >> >>> On Sep 4, 2019, at 11:43 AM, Alexei Starovoitov wrote: >>> >>> Implement permissions as stated in uapi/linux/capability.h >>> >>> Signed-off-by: Alexei Starov

Re: [PATCH v3 bpf-next 2/3] bpf: implement CAP_BPF

2019-09-04 Thread Alexei Starovoitov
On Thu, Sep 05, 2019 at 12:34:36AM +, Song Liu wrote: > > > > On Sep 4, 2019, at 11:43 AM, Alexei Starovoitov wrote: > > > > Implement permissions as stated in uapi/linux/capability.h > > > > Signed-off-by: Alexei Starovoitov > > > > [...] > > > @@ -1648,11 +1648,11 @@ static int bpf_p

Re: [PATCH v3 bpf-next 2/3] bpf: implement CAP_BPF

2019-09-04 Thread Song Liu
> On Sep 4, 2019, at 11:43 AM, Alexei Starovoitov wrote: > > Implement permissions as stated in uapi/linux/capability.h > > Signed-off-by: Alexei Starovoitov > [...] > @@ -1648,11 +1648,11 @@ static int bpf_prog_load(union bpf_attr *attr, union > bpf_attr __user *uattr) > is_gpl =

[PATCH v3 bpf-next 2/3] bpf: implement CAP_BPF

2019-09-04 Thread Alexei Starovoitov
Implement permissions as stated in uapi/linux/capability.h Signed-off-by: Alexei Starovoitov --- kernel/bpf/arraymap.c | 2 +- kernel/bpf/cgroup.c | 2 +- kernel/bpf/core.c | 4 +- kernel/bpf/hashtab.c